[CPS-6393]fix(resync): resync the release controller when occured unknown error #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caicloud-bot
added
release-note-none
qianlei90
reviewed
Apr 16, 2020
默认 30s |
|
/lgtm |
caicloud-bot
added
lgtm
|
/hold |
caicloud-bot
added
the
do-not-merge/hold
|
/cc @hezhizhen |
|
/hold cancel |
caicloud-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hezhizhen, qianlei90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.4 |
|
@whalecold: #152 failed to apply on top of branch "release-0.4": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
whalecold
added a commit
to whalecold/rudder
that referenced
this pull request
Jun 19, 2020
…nown error (caicloud#152) * [CPS-6393]fix(resync): resync the release controller when occured unknown error * use time.During instead of int32 Co-authored-by: Lisheng Zheng <zhenglisheng@caicloud.io>
whalecold
pushed a commit
to whalecold/rudder
that referenced
this pull request
Jun 19, 2020
…nown error (caicloud#152) * [CPS-6393]fix(resync): resync the release controller when occured unknown error * use time.During instead of int32 Co-authored-by: Lisheng Zheng <zhenglisheng@caicloud.io>
whalecold
pushed a commit
to whalecold/rudder
that referenced
this pull request
Jun 23, 2020
…nown error (caicloud#152) * [CPS-6393]fix(resync): resync the release controller when occured unknown error * use time.During instead of int32 Co-authored-by: Lisheng Zheng <zhenglisheng@caicloud.io>
caicloud-bot
pushed a commit
that referenced
this pull request
Jun 28, 2020
…known error (#152) (#156) * [CPS-6393]fix(resync): resync the release controller when occured unknown error (#152) * [CPS-6393]fix(resync): resync the release controller when occured unknown error * use time.During instead of int32 Co-authored-by: Lisheng Zheng <zhenglisheng@caicloud.io> * fix lint error Co-authored-by: Lisheng Zheng <zhenglisheng@caicloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @qianlei90 @hezhizhen
Release note: