-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Frosting #260
Conversation
This looks brilliant, I need some time to process this. (Setting |
Does this also fix the inconsistency I observed in #255 ? |
I have started working on this on 212, mostly namespaces changed so it would be trivial to port to another version, just not with the same .jar/.dll
I have not looked into it yet, will do later |
I tested your code before the last commit you made. Will test again tomorrow. Looks really cool so far. One addition: If I open up a single frosting project (without a containing solution) the project picker in the run configuration does not list the project to be built.
Since we have no snippets in the other IDEs to copy from, yes - let's go with that and see if more is needed.
Not sure. I'd need to investigate. cake-rider/src/rider/src/main/kotlin/net/cakebuild/liveTemplates/CakeContext.kt Lines 8 to 13 in aa0cdc6
and check for projects of type frosting and Also, I'm not sure why the build currently fails - something with GitVersion being unable to calculate a nice version number for this PR. (Probably because I merged |
and modified the code accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@js6pak your changes have been merged, thanks for your contribution 👍 I took the liberty to fix the linting problems in kotlin and also changed some styling in c#. Hope you don't mind. |
Closes #129, closes #255, closes #52
run configurations
gutter icon
tool window
(Special icons for cake script and cake frosting would be nice)
snippets
convert cake script configuration editor to ControlViewBuilder
I took a very "do it as rider would" approach in this PR and ended up using a lot of rider types which changed quite a bit in rider 2022 (I suppose because of the unreal engine support) upping the version requirement.