Add samesite attribute and change spelling of config-key #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The samesite-attribute is missing in the configuration-array and the spelling of the config-key 'httpOnly' is deprecated.
markstory
reviewed
Jul 29, 2020
The samesite-attribute is missing in the configuration-array and the spelling of the config-key 'httpOnly' is deprecated.
ADmad
reviewed
Jul 29, 2020
The samesite-attribute is missing in the configuration-array and the spelling of the config-key 'httpOnly' is deprecated.
Switched to Cookie::create() to decouple configuration options of the Cookie-Authenticator from the Cookie object. So you can use the samesite attribute (or what may come in the future) without changing the Cookie Authenticator. As a side effect the spelling is unified (httpOnly vs. httponly).
ADmad
reviewed
Jul 31, 2020
|
Uhh. I have to fix backwards-compatibility-issues before trying another merge. |
I'll take care of it. |
ADmad
added a commit
that referenced
this pull request
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The samesite-attribute is missing in the configuration-array and the spelling of the config-key 'httpOnly' is deprecated in CookieInterface.