Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to book a slot that conflicts with a smaller event within the slot #79

Closed
emrysal opened this issue Apr 20, 2021 · 2 comments
Closed

Comments

@emrysal
Copy link
Contributor

emrysal commented Apr 20, 2021

Bit of an accidental find; When booking a slot, if the slot being booked > the length of an existing event E.g. I have an event in my calendar from 9:15 until 9:30, this is properly blocked from booking in 15 minute booking slot times, but if I by chance have 1-hour event types as well, I am still able to book 9:00-10:00. This is due to the code checking whether the slot you are booking time is between the start and end busyTime, but not whether the slot you are booking overlaps with a smaller, other event.

@baileypumfleet
Copy link
Contributor

I think that maybe #180 may fix this?

@emrysal
Copy link
Contributor Author

emrysal commented Jul 5, 2021

This is indeed fixed nowadays :)

@emrysal emrysal closed this as completed Jul 5, 2021
zomars pushed a commit that referenced this issue May 23, 2023
fix: event type jsonschema or znull
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants