fix: check for overlapping appointments #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parasg1999 is attempting to deploy a commit to the calendso Team on Vercel. A member of the Team first needs to authorize it. |
|
This is awesome, thanks very much for your contribution, and welcome to Calendso! |
|
Thanks @baileypumfleet 🎉 |
This was referenced May 10, 2021
Closed
KATT
pushed a commit
that referenced
this pull request
Sep 3, 2021
Bumps [start-server-and-test](https://github.com/bahmutov/start-server-and-test) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/bahmutov/start-server-and-test/releases) - [Commits](bahmutov/start-server-and-test@v1.12.0...v1.12.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Came across this as I was facing the overlapping issue in app.cal.com; Please refer the below screenshot where two overlapping bookings were allowed. Not sure if this fix was applied to app.cal.com or not
|
zomars
added a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case where a 45 minute slot was available for 5:45pm but my 6:00pm was already booked. This PR fixes the situation where the slot end time could be in one of the busy slots.
Please give any suggestions. I love calendso and would love to contribute more.
Edit
The second commit is for the situations where my slot starts at let's say 5:30 pm and ends at 6:00pm, but I am busy from 5:40 to 5:50, then none of the previous checks will work.
Suggestion -
I think we should get slots after checking the busy schedule
But this can be done at a later stage.