fix: use org logo for sub teams #13632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
enterprise
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 447 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 02/12/2024 02:06:11pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 312f523 Started: 02/12/2024 01:55:46pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Multiple Email Question and Each Other Question Booking With Multiple Email Question and Radio group Question Booking With Multiple Email Question and select Question Multiple Email and select not required
Retry 1 • Initial Attempt |
0% (0)0 / 279 runsfailed over last 7 days |
3.58% (10)10 / 279 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- future Time slots should be reserved when selected
Retry 1 • Initial Attempt |
0.36% (1)1 / 278 runfailed over last 7 days |
8.63% (24)24 / 278 runsflaked over last 7 days |
📄 apps/web/playwright/booking/longTextQuestion.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Long Text Question and Each Other Question Booking With Long Text Question and checkbox Question Long Text and checkbox required
Retry 1 • Initial Attempt |
0.35% (1)1 / 287 runfailed over last 7 days |
5.57% (16)16 / 287 runsflaked over last 7 days |
📄 apps/web/playwright/booking/checkboxGroupQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and checkbox Question Checkbox Group required and checkbox required
Retry 1 • Initial Attempt |
0% (0)0 / 291 runsfailed over last 7 days |
7.22% (21)21 / 291 runsflaked over last 7 days |
|
Booking With Checkbox Group Question and Each Other Question Booking With Checkbox Group Question and Address Question Booking With Checkbox Group Question and Short text question Checkbox Group required and Short Text required
Retry 1 • Initial Attempt |
0% (0)0 / 288 runsfailed over last 7 days |
7.99% (23)23 / 288 runsflaked over last 7 days |
📄 apps/web/playwright/booking/radioGroupQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and Long text Question Radio and Long text not required
Retry 1 • Initial Attempt |
0% (0)0 / 288 runsfailed over last 7 days |
7.29% (21)21 / 288 runsflaked over last 7 days |
|
Booking With Radio Question and Each Other Question Booking With Radio Question and Address Question Booking With Radio Question and select Question Radio and select not required
Retry 1 • Initial Attempt |
0% (0)0 / 285 runsfailed over last 7 days |
5.61% (16)16 / 285 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
4.88% (14)14 / 287 runsfailed over last 7 days |
39.02% (112)112 / 287 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Webhook tests FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1 • Initial Attempt |
3.46% (10)10 / 289 runsfailed over last 7 days |
14.53% (42)42 / 289 runsflaked over last 7 days |
📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Long text Question Phone and Long text required
Retry 1 • Initial Attempt |
0.34% (1)1 / 295 runfailed over last 7 days |
7.12% (21)21 / 295 runsflaked over last 7 days |
|
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone required and multiselect text not required
Retry 1 • Initial Attempt |
0.34% (1)1 / 293 runfailed over last 7 days |
4.78% (14)14 / 293 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 308 runsfailed over last 7 days |
6.49% (20)20 / 308 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Cannot update a users email when existing user has same email (verification enabled)
Retry 1 • Initial Attempt |
0% (0)0 / 128 runsfailed over last 7 days |
50.78% (65)65 / 128 runsflaked over last 7 days |
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
13.04% (18)18 / 138 runsfailed over last 7 days |
53.62% (74)74 / 138 runsflaked over last 7 days |
PeerRich
previously approved these changes
Feb 10, 2024
| : getTeamAvatarUrl({ | ||
| slug: team.slug, | ||
| requestedSlug: team.metadata?.requestedSlug ?? null, | ||
| organizationId: team.parentId, |
There was a problem hiding this comment.
Seems odd that we are in the else of the ternary that is getting a non-org URL but yet we are passing an organizationId.
Is this still needed or can we refactor?
There was a problem hiding this comment.
Let me see what I can do
There was a problem hiding this comment.
We’re not necessarily in a non org situation - we’re just in a situation where a sub team has a org as a parent 🤔
keithwillcode
approved these changes
Feb 12, 2024
keithwillcode
deleted the
sean/cal-2844-organisation-subteams-should-have-org-logo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12956
Use org logo for any org sub teams.