feat: Workflow — Send Email to Specific Email #14815

Amit91848 · 2024-04-30T16:58:05Z

What does this PR do?

Fixes #14466

I don't have sendgrid account cannot show the email, instead showing the logs.

Screen.Recording.2024-04-30.at.10.17.05.PM.mov

Pending

~~Table for Verified Emails like there is of VerifiedNumber~~

Type of change

Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2024-04-30T16:58:11Z

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-04-30T16:58:17Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

graphite-app · 2024-04-30T17:00:13Z

Graphite Automations

"Add community label" took an action on this PR • (04/30/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (04/30/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (05/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2024-04-30T17:13:10Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/workflows/[workflow]`	`412.17 KB`	640.72 KB	183.06% (🟡 +0.15%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

CarinaWolli

Great work so far, I left you some comments that need to be addressed first 🙏

And I think the implemenation for EMAIL_ADRESSE is missing in activateEventType.handler.ts

packages/trpc/server/routers/viewer/workflows/getVerifiedEmails.handler.ts

CarinaWolli · 2024-05-02T15:43:40Z

packages/trpc/server/routers/viewer/workflows/getVerifiedEmails.handler.ts

+
+export const getVerifiedEmailsHandler = async ({ ctx, input }: GetVerifiedEmailsOptions) => {
+  const { user } = ctx;
+  const verifiedEmails = await prisma.verifiedEmail.findMany({


If it's a team workflow, I think it would be nice to show all emails of team members automatically as verified.

CarinaWolli · 2024-05-02T15:50:46Z

packages/trpc/server/routers/viewer/workflows/update.handler.ts

-                /*case WorkflowActions.EMAIL_ADDRESS:
-                      sendTo = step.sendTo || "";*/
+                case WorkflowActions.EMAIL_ADDRESS:
+                  sendTo = step.sendTo ? [step.sendTo] : [];


Let's add a check to make sure that the sendTo email is actually verified. Also if it is a team workflow and we find that the email is verified for the user only let's add the team to the verifiedEmail as well.

That would solve the following issue:
Member1 has a user workflow and verifies an email to use in this workflow. Member1 creates a team workflow and uses the same email again which automatically shows as verified. Member2 tries to edit the team workflow but the email doesn't show as verified for them and they can't make any changes before they verify the email themselves

packages/trpc/server/routers/viewer/workflows/update.handler.ts

Amit91848 · 2024-05-05T17:46:33Z

Made changes @CarinaWolli

CarinaWolli

Right now not verified emails can be saved to the workflow, we should add an error message like for SMS to specific number:

Can we change the title of the email form 'Cal.com: Verify your account' to 'Cal.com: Verify your email'

packages/trpc/server/routers/viewer/workflows/update.handler.ts

Amit91848 · 2024-05-13T09:19:47Z

Also cannot open workflow page, keep getting this error.

CarinaWolli · 2024-05-13T14:15:16Z

Also cannot open workflow page, keep getting this error.

For the getStaticProps() error, can you try to set the env variable APP_ROUTER_WORKFLOWS_ENABLED to 0

packages/trpc/server/routers/viewer/workflows/update.handler.ts

Amit91848 · 2024-05-13T16:19:53Z

Also cannot open workflow page, keep getting this error.

For the getStaticProps() error, can you try to set the env variable APP_ROUTER_WORKFLOWS_ENABLED to 0

Was already 0, tried with 1 also, still getting the same error

CarinaWolli · 2024-05-13T17:02:02Z

Also cannot open workflow page, keep getting this error.

For the getStaticProps() error, can you try to set the env variable APP_ROUTER_WORKFLOWS_ENABLED to 0

Was already 0, tried with 1 also, still getting the same error

did you restart the yarn dev server after changing the env. variable? For me it works, I am getting the same error if I set the env variable to 1

Amit91848 · 2024-05-13T17:13:26Z

did you restart the yarn dev server after changing the env. variable? For me it works, I am getting the same error if I set the env variable to 1

Yup still getting the same error

Screen.Recording.2024-05-13.at.10.40.42.PM.mov

Works if i comment this tho

cal.com/apps/web/middleware.ts

Line 169 in 56f31ee

middleware: abTestMiddlewareFactory(middleware),

…nd_email_to_specific_email

Amit91848 · 2024-05-13T18:10:00Z

Made changes @CarinaWolli

packages/trpc/server/routers/viewer/workflows/update.handler.ts

CarinaWolli · 2024-05-17T20:35:36Z

packages/trpc/server/routers/viewer/workflows/update.handler.ts

-                /*case WorkflowActions.EMAIL_ADDRESS:
-                      sendTo = step.sendTo || "";*/
+                case WorkflowActions.EMAIL_ADDRESS:
+                  await verifyEmailSender(newStep.sendTo || "", user.id, userWorkflow.teamId, ctx.prisma);


for added steps we only call it when we have bookings that need reminders scheduled. We should do it the same as we do for the edited steps

Yeah removed it from here and added when creating new step

CarinaWolli

Great work, all issues are resolved and it is working as expected 🙏

* feat: Workflow — Send Email to Specific Email * disable button when verifyEmail pending * add verified emails table and routes * fix: include teamId in verifyEmailCode * fix: include email address in activate handler * fix: check team before adding email * feat: check verified email, add to team if only users * remove logs * fix: if statement Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com> * change email to verify your email * fix: show error if saving unverified email * fix: show email in subject * verify email when editing steps * remove double calls from same block * verify email when creating new step --------- Co-authored-by: v0ltZzie <161201747+v0ltZzie@users.noreply.github.com> Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>

feat: Workflow — Send Email to Specific Email

1aeb6ba

github-actions bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email Medium priority Created by Linear-GitHub Sync workflows area: workflows, automations ✨ feature New feature or request labels Apr 30, 2024

graphite-app bot added the community Created by Linear-GitHub Sync label Apr 30, 2024

graphite-app bot requested a review from a team April 30, 2024 16:58

CarinaWolli added this to the v4.1 milestone Apr 30, 2024

Amit91848 and others added 3 commits May 1, 2024 10:38

disable button when verifyEmail pending

a01c3b4

Merge branch 'main' into feat/send_email_to_specific_email

ddb3ac5

add verified emails table and routes

001f8c7

github-actions bot added the ❗️ migrations contains migration files label May 1, 2024

CarinaWolli requested changes May 2, 2024

View reviewed changes

Amit91848 added 4 commits May 5, 2024 17:10

fix: include teamId in verifyEmailCode

1688010

fix: include email address in activate handler

7936bee

fix: check team before adding email

52c6ba4

feat: check verified email, add to team if only users

e531fcb

Amit91848 commented May 5, 2024

View reviewed changes

packages/trpc/server/routers/viewer/workflows/update.handler.ts Show resolved Hide resolved

Amit91848 commented May 5, 2024

View reviewed changes

packages/trpc/server/routers/viewer/workflows/update.handler.ts Show resolved Hide resolved

Amit91848 added 2 commits May 5, 2024 23:13

remove logs

dc472aa

Merge branch 'main' into feat/send_email_to_specific_email

2290d7c

Amit91848 requested a review from CarinaWolli May 5, 2024 17:46

CarinaWolli requested changes May 9, 2024

View reviewed changes

packages/trpc/server/routers/viewer/workflows/update.handler.ts Show resolved Hide resolved

packages/trpc/server/routers/viewer/workflows/update.handler.ts Outdated Show resolved Hide resolved

dosubot bot modified the milestones: v4.1, v4.2 May 9, 2024

change email to verify your email

99bc82e

CarinaWolli reviewed May 13, 2024

View reviewed changes

packages/trpc/server/routers/viewer/workflows/update.handler.ts Show resolved Hide resolved

Amit91848 added 2 commits May 13, 2024 17:36

fix: show error if saving unverified email

fd115fb

fix: show email in subject

47fbbf8

graphite-app bot requested a review from a team May 13, 2024 18:00

Merge branch 'main' of https://github.com/calcom/cal.com into feat/se…

ebe82fb

…nd_email_to_specific_email

Amit91848 requested a review from CarinaWolli May 13, 2024 18:10

Merge branch 'main' into feat/send_email_to_specific_email

fee5071

dosubot bot added this to the v4.2 milestone May 15, 2024

CarinaWolli requested changes May 16, 2024

View reviewed changes

packages/trpc/server/routers/viewer/workflows/update.handler.ts Show resolved Hide resolved

Amit91848 and others added 2 commits May 17, 2024 17:18

verify email when editing steps

f4927a3

Merge branch 'main' into feat/send_email_to_specific_email

abf5acf

Amit91848 requested a review from CarinaWolli May 17, 2024 17:25

remove double calls from same block

cba306e

CarinaWolli reviewed May 17, 2024

View reviewed changes

verify email when creating new step

8deeb77

Amit91848 requested a review from CarinaWolli May 18, 2024 09:42

CarinaWolli approved these changes May 20, 2024

View reviewed changes

CarinaWolli enabled auto-merge (squash) May 20, 2024 16:15

CarinaWolli added 2 commits May 20, 2024 12:15

Merge branch 'main' into feat/send_email_to_specific_email

40cbdc9

Merge branch 'main' into feat/send_email_to_specific_email

86e95ba

CarinaWolli merged commit bd6c471 into calcom:main May 20, 2024
32 of 40 checks passed

p6l-richard mentioned this pull request Jul 24, 2024

fix(marketing): move the sitemap for search engines to core app #15893

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Workflow — Send Email to Specific Email #14815

feat: Workflow — Send Email to Specific Email #14815

Amit91848 commented Apr 30, 2024 •

edited

Loading

vercel bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024 •

edited

Loading

graphite-app bot commented Apr 30, 2024 •

edited

Loading

github-actions bot commented Apr 30, 2024 •

edited

Loading

CarinaWolli left a comment

CarinaWolli May 2, 2024

CarinaWolli May 2, 2024

Amit91848 commented May 5, 2024

CarinaWolli left a comment •

edited

Loading

Amit91848 commented May 13, 2024

CarinaWolli commented May 13, 2024

Amit91848 commented May 13, 2024

CarinaWolli commented May 13, 2024

Amit91848 commented May 13, 2024

Amit91848 commented May 13, 2024

CarinaWolli May 17, 2024

Amit91848 May 18, 2024

CarinaWolli left a comment

feat: Workflow — Send Email to Specific Email #14815

feat: Workflow — Send Email to Specific Email #14815

Conversation

Amit91848 commented Apr 30, 2024 • edited Loading

What does this PR do?

Pending

Type of change

Mandatory Tasks

vercel bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024 • edited Loading

graphite-app bot commented Apr 30, 2024 • edited Loading

Graphite Automations

github-actions bot commented Apr 30, 2024 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

One Page Changed Size

CarinaWolli left a comment

Choose a reason for hiding this comment

CarinaWolli May 2, 2024

Choose a reason for hiding this comment

CarinaWolli May 2, 2024

Choose a reason for hiding this comment

Amit91848 commented May 5, 2024

CarinaWolli left a comment • edited Loading

Choose a reason for hiding this comment

Amit91848 commented May 13, 2024

CarinaWolli commented May 13, 2024

Amit91848 commented May 13, 2024

CarinaWolli commented May 13, 2024

Amit91848 commented May 13, 2024

Amit91848 commented May 13, 2024

CarinaWolli May 17, 2024

Choose a reason for hiding this comment

Amit91848 May 18, 2024

Choose a reason for hiding this comment

CarinaWolli left a comment

Choose a reason for hiding this comment

Amit91848 commented Apr 30, 2024 •

edited

Loading

github-actions bot commented Apr 30, 2024 •

edited

Loading

graphite-app bot commented Apr 30, 2024 •

edited

Loading

github-actions bot commented Apr 30, 2024 •

edited

Loading

CarinaWolli left a comment •

edited

Loading