Skip to content

Fix several issues #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Fix several issues #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db5dd24
Fix camel case in strings
laurentdavid Nov 7, 2022
bc33118
Fix issue with behat
laurentdavid Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Featured courses #

[![Moodle Plugin CI](https://github.com/martin-call-learning/moodle-block_featured_courses/actions/workflows/main.yml/badge.svg)](https://github.com/martin-call-learning/moodle-block_featured_courses/actions/workflows/main.yml)

[![Build Status](https://travis-ci.org/call-learning/moodle-block-featured_courses.svg?branch=master)](https://travis-ci.org/call-learning/moodle-block-featured_courses)
[![Moodle Plugin CI](https://github.com/call-learning/moodle-block_featured_courses/actions/workflows/main.yml/badge.svg)](https://github.com/call-learning/moodle-block_featured_courses/actions/workflows/main.yml)

A block to display of courses from the global list of courses.

Expand Down
4 changes: 2 additions & 2 deletions lang/en/block_featured_courses.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@
$string['config:selectedcourses'] = 'Selected course {no}';
$string['featured_courses:addinstance'] = 'Add a featured_courses block';
$string['featured_courses:myaddinstance'] = 'Add a featured_courses block to my moodle';
$string['pluginname'] = 'Featured Courses';
$string['pluginname'] = 'Featured courses';
$string['removelastcourses'] = 'Remove last course';
$string['viewcourse'] = 'View Course';
$string['viewcourse'] = 'View course';
10 changes: 5 additions & 5 deletions tests/behat/block_featured_courses.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ Feature: Add a featured block on the dashboard
Scenario: Add the block and set 3 featured courses
Given I log in as "admin"
Then I am on homepage
And I turn editing mode on
When I press "Customise this page"
And I add the "Featured Courses" block
And I configure the "Featured Courses" block
And I configure the "Featured courses" block
And I expand all fieldsets
Then I should see "Title"
And I set the field "Title" to "My featured courses"
Expand All @@ -34,9 +34,9 @@ Feature: Add a featured block on the dashboard
@javascript
Scenario: Add the block and set 3 featured courses and remove one after, only two should display
Given I log in as "admin"
Then I turn editing mode on
And I add the "Featured Courses" block
And I configure the "Featured Courses" block
When I press "Customise this page"
Then I add the "Featured courses" block
And I configure the "Featured courses" block
And I expand all fieldsets
Then I should see "Title"
And I set the field "Title" to "My featured courses"
Expand Down