Refactor mcm #2
Merged
Refactor mcm #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-call-learning
force-pushed
the
refactor_mcm
branch
2 times, most recently
from
e1977ac to
d795b7a
Compare
|
Here is my last version for now, everything works well for me, tell me if there is anything to add. |
martin-call-learning
force-pushed
the
refactor_mcm
branch
2 times, most recently
from
ed6cb9d to
2a3aa68
Compare
|
Sorry for the force pushes but some checks in the github actions aren't in run-ci.sh, this should be the last one. |
* End of the dependency with rss_client * Use of SimpleXML instead of Simplepie * Changed carousselspeed into caroussel delay * Updated & validated workflow * New tests * Validated run-ci.sh * Added some TODOs for future * Fixed phpdoc of all files
martin-call-learning
force-pushed
the
refactor_mcm
branch
from
2a3aa68 to
e5ffbcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the "alpha" refactor code
Still have to rebase on the current master branch & validate workflow