Danmarsden fixes #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martin-call-learning
commented
Nov 10, 2022
martin-call-learning
commented
- Separated the class edit into a single class name feed_edit -> fixes editfeed.php contains mix of classes and inline php code #6
- Added namespaces for editfeed and form/feed_edit -> fixes incorrect class name "feed_edit_form" #5
- Added thirdpartylibs.xml -> fixes missing thirdpartylibs.xml file. #3
- Added a check at the start of block_rss_thumbnails::get_content so the method will no longer compute twice -> fixes block get_content() is called twice on page load. #4
- Added a check to be able to display a message whenever an user did not fill all of the configuration fields. So it won't take the plugin down.
* Separated the class edit into a single class name feed_edit -> fixes call-learning#6 * Added namespaces for editfeed and form/feed_edit -> fixes call-learning#5 * Added thirdpartylibs.xml -> fixes call-learning#3 * Added a check at the start of block_rss_thumbnails::get_content so the method will no longer compute twice -> fixes call-learning#4
martin-call-learning
force-pushed
the
danmarsden-fixes
branch
from
1a29af6 to
b8711f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.