Skip to content

Conversation

hurali97
Copy link
Member

Summary

This PR fixes an edge case where in an expo project, if the consumer android library has the name starting before expo then it gets evaluated after expo, hence the expo libraries are not linked with the android library. To fix that behavior, we add a dependency on expo evaluation and then the consumer android library gets evaluated. This ensures that the expo libraries will be present and linked correctly with the android library when it is evaluated.

Issue fixed: #135

Test plan

  • In an expo project, create a brownfield library where name starts from a | b | c | d | e for eg, :brownlibrary | :expobrownfieldlibrary
  • Generate the AAR, consume it and make sure the host android app does not crash

  • Follow the similar steps but with library name starting after the letter e, for eg: :mylibrary

  • Verify the non-expo project, having the android library works fine after these changes

Screen.Recording.2025-09-20.at.4.35.22.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo support only works if library name comes after "expo" alphabetically
1 participant