Skip to content

chore: migrate circleci workflow to github actions #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Sep 9, 2022

Summary

We have a workflow that runs on circleci.

This workflow basically:

  1. Checks out the repo
  2. Installs dependencies
  3. Runs yarn lint
  4. Runs yarn lerna run prepare
  5. Runs yarn typescript

I have implemented the same workflow using github actions and then removed the old workflow for circleci

Test plan

Create a pull request to merge your branch into main

@atlj atlj changed the title chore: switch circleci workflow to github actions chore: migrate circleci workflow to github actions Sep 9, 2022
@atlj atlj requested a review from satya164 September 9, 2022 15:52
Copy link
Contributor

@MateWW MateWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job! 🥳🚀

@satya164 satya164 merged commit 3e4ec70 into main Sep 12, 2022
@satya164 satya164 deleted the @atlj/convert-circleci-ghactions branch September 12, 2022 13:33
satya164 added a commit that referenced this pull request Mar 27, 2025
satya164 added a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants