Skip to content

feat: add option to specify tsc path #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2020
Merged

feat: add option to specify tsc path #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fc4478
feat: added tsc path option for typescript target
Mar 24, 2020
f58db1e
fix: update readme
Mar 24, 2020
6faa623
fix: incorporated feedback
Mar 28, 2020
7335dff
fix: updated error/warning message
Mar 28, 2020
99569b2
Apply suggestions from code review
satya164 May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ Example:

Enable generating type definitions with `tsc` if your source code is written in [TypeScript](http://www.typescriptlang.org/).

By default, it'll use the `tsconfig.json` file in your project root. If you want to use a different config, you can specify it using the `project` option.
By default, it'll use the `tsconfig.json` file in your project root. If you want to use a different config, you can specify it using the `project` option. Furthermore, the tsc binary will be resolved to ./node_modules/.bin/tsc. Use the `tsc` option to specify a different path.

Example:

Expand Down
16 changes: 10 additions & 6 deletions src/targets/typescript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { platform } from 'os';
import { Input } from '../types';

type Options = Input & {
options?: { project?: string };
options?: { project?: string; tsc?: string };
};

export default async function build({
Expand Down Expand Up @@ -78,9 +78,9 @@ export default async function build({
);
}

let tsc =
path.join(root, 'node_modules', '.bin', 'tsc') +
(platform() === 'win32' ? '.cmd' : '');
let tsc = options?.tsc
? path.resolve(root, options.tsc)
: path.join(root, 'node_modules') + (platform() === 'win32' ? '.cmd' : '');

if (!(await fs.pathExists(tsc))) {
tsc = spawn
Expand All @@ -93,7 +93,9 @@ export default async function build({
'tsc'
)}. Consider adding ${chalk.blue('typescript')} to your ${chalk.blue(
'devDependencies'
)} instead.`
)} or specifying the ${chalk.blue(
'tsc'
)} option for the typescript target.`
);
}

Expand Down Expand Up @@ -127,7 +129,9 @@ export default async function build({
'node_modules'
)} or present in $PATH. Make sure you have added ${chalk.blue(
'typescript'
)} to your ${chalk.blue('devDependencies')}.`
)} to your ${chalk.blue('devDependencies')} or specify the ${chalk.blue(
'tsc'
)} option for typescript.`
);
}
} catch (e) {
Expand Down