Skip to content

fix: scrollEnabled prop, when comp is loaded dynamically #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

fix: scrollEnabled prop, when comp is loaded dynamically #102

merged 1 commit into from
Nov 20, 2019

Conversation

troZee
Copy link
Collaborator

@troZee troZee commented Nov 12, 2019 •
edited
Loading

Summary

Close #99
Close #96

Compatibility

OS Implemented
iOS ✅
Android ❌

Checklist

  • I have tested this on a device and a simulator

@troZee troZee requested a review from dratwas November 12, 2019 14:56
@ferrannp ferrannp merged commit 313e703 into master Nov 20, 2019
@ferrannp ferrannp deleted the troZee/fix-scroll-enable branch November 20, 2019 10:16
@fcostarelli-tbox
Copy link

This fixed it for me, but only if transitionStyle={'scroll'}. When set to curl I can still scroll even with scrollEnabled={false}. Any suggestion on how this could be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dratwas dratwas Awaiting requested review from dratwas

1 more reviewer

@ferrannp ferrannp ferrannp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(iOS) scrollEnabled={false} not applying when mounting dynamically scrollEnabled={false} does not work for IOS
3 participants
@troZee @fcostarelli-tbox @ferrannp