[iOS] Disable content touches when ViewPager is scrolling #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
reviewed
Dec 10, 2019
troZee
force-pushed
the
@troZee/disable-touch-events
branch
from
3ee060c to
50cd78d
Compare
dratwas
approved these changes
Dec 11, 2019
|
Approved, however, I don't like the |
|
may i ask when will this PR be merged and on npm? |
grahammendick
added a commit
to grahammendick/navigation
that referenced
this pull request
Jul 23, 2020
Used to do this by intercepting touch but there's no ios equivalent. Took the idea from callstack/react-native-pager-view#124
alpha0010
added a commit
to alpha0010/react-native-viewpager
that referenced
this pull request
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Android when ViewPager is scrolling with swipe gesture all content(including all Touchables) are disabled. On iOS it's not - all touchables are interactable while swiping so when viewpager content has button or other clickable components they are clicked.
Close #73
Test Plan
Click on button, while scrolling. Check if no of likes increased.
Compatibility
Checklist