-
Notifications
You must be signed in to change notification settings - Fork 453
fix: prevent touch events to be executed during swipe #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 18 additions & 17 deletions
35
android/src/main/java/com/reactnativecommunity/viewpager/FragmentAdapter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,71 +1,72 @@ | ||
| package com.reactnativecommunity.viewpager; | ||
|
|
||
| import android.view.View; | ||
| import android.view.ViewGroup; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import androidx.fragment.app.Fragment; | ||
| import androidx.fragment.app.FragmentActivity; | ||
| import androidx.viewpager2.adapter.FragmentStateAdapter; | ||
|
|
||
| import com.reactnative.community.viewpager2.adapter.FragmentStateAdapter; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| public class FragmentAdapter extends FragmentStateAdapter { | ||
|
|
||
| private List<View> childrenViews = new ArrayList<>(); | ||
| public FragmentAdapter(@NonNull FragmentActivity fragmentActivity) { | ||
| super(fragmentActivity); | ||
| } | ||
|
|
||
| private ArrayList<Integer> childrenViewIDs = new ArrayList<>(); | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public Fragment createFragment(int position) { | ||
| return ViewPagerFragment.newInstance(childrenViewIDs.get(position)); | ||
| return new ViewPagerFragment(childrenViews.get(position)); | ||
| } | ||
|
|
||
| @Override | ||
| public int getItemCount() { | ||
| return childrenViewIDs.size(); | ||
| return childrenViews.size(); | ||
| } | ||
|
|
||
| @Override | ||
| public long getItemId(int position) { | ||
| return childrenViewIDs.get(position); | ||
| return childrenViews.get(position).getId(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean containsItem(long itemId) { | ||
| return childrenViewIDs.contains((int) itemId); | ||
| for(View child: childrenViews) { | ||
| if((int) itemId == child.getId()) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| public void addFragment(View child, int index) { | ||
| childrenViewIDs.add(index, child.getId()); | ||
| childrenViews.add(index, child); | ||
| notifyItemInserted(index); | ||
| } | ||
|
|
||
| public void removeFragment(View child) { | ||
| int index = childrenViewIDs.indexOf(child.getId()); | ||
| int index = childrenViews.indexOf(child); | ||
| removeFragmentAt(index); | ||
| } | ||
|
|
||
| public void removeFragmentAt(int index) { | ||
| childrenViewIDs.remove(index); | ||
| childrenViews.remove(index); | ||
| notifyItemRemoved(index); | ||
| } | ||
|
|
||
| public void removeAll() { | ||
| childrenViewIDs.clear(); | ||
| childrenViews.clear(); | ||
| notifyDataSetChanged(); | ||
| } | ||
|
|
||
| public List<Integer> getChildrenViewIDs() { | ||
| return Collections.unmodifiableList(childrenViewIDs); | ||
| } | ||
|
|
||
| public int getChildViewIDAt(int index) { | ||
| return childrenViewIDs.get(index); | ||
| public View getChildViewAt(int index) { | ||
| return childrenViews.get(index); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.