Skip to content

Ignore all node_modules #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2022
Merged

Ignore all node_modules #353

merged 1 commit into from
Feb 1, 2022

Conversation

BartoszKlonowski
Copy link
Member

This pull request ignores all libraries in node_modules directory when it comes to flow checks.

Reasoning behind it:

All comments against this change are welcomed.

@BartoszKlonowski BartoszKlonowski added the dependencies Pull requests that update a dependency file label Jan 31, 2022
mosoakinyemi
mosoakinyemi approved these changes Feb 1, 2022
View reviewed changes
Copy link

@mosoakinyemi mosoakinyemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BartoszKlonowski BartoszKlonowski merged commit 09c8680 into main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deorst deorst Awaiting requested review from deorst

1 more reviewer

@mosoakinyemi mosoakinyemi mosoakinyemi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BartoszKlonowski @mosoakinyemi