Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bring back RenderAPI type #1000

Merged
merged 3 commits into from
Jun 24, 2022
Merged

fix: bring back RenderAPI type #1000

merged 3 commits into from
Jun 24, 2022

Conversation

thymikee
Copy link
Member

Summary

Fixes #999

Test plan

Added test

@mdjastrzebski
Copy link
Member

I would prefer RenderResult for RTL-compat purposes, but that would probably be a breaking change.

@thymikee
Copy link
Member Author

@mdjastrzebski we can introduce it along with screen PR :) there's nothing wrong with exporting it as an alias and deprecate in the future

@gkartalis
Copy link
Contributor

👏 👏 👏 Thanks for addressing that so quickly!

@thymikee thymikee merged commit 8d69c40 into main Jun 24, 2022
@thymikee thymikee deleted the fix/renderapi-type branch June 24, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjastrzebski mdjastrzebski mdjastrzebski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RenderAPI type not exported anymore?
3 participants
@thymikee @mdjastrzebski @gkartalis