Skip to content

feat: support multiple params in event handlers #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

feat: support multiple params in event handlers #203

merged 1 commit into from
Jul 16, 2019

Conversation

Esemesek
Copy link
Collaborator

Summary

Allow user to pass multiple parameters into the event handler function.

fireEvent(getByA11yLabel('some-button'), 'customPress', '1st param', '2nd param');

Test plan

Added UT, and Typescript tests.

@Esemesek Esemesek requested a review from thymikee July 16, 2019 14:15
@thymikee thymikee changed the title imp: Multiple params in event handlers feat: support multiple params in event handlers Jul 16, 2019
@thymikee thymikee merged commit 31f476b into master Jul 16, 2019
@thymikee thymikee deleted the event-params branch July 16, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Esemesek @thymikee