Skip to content

Conversation

okwasniewski
Copy link
Collaborator

PR Description

This PR drops old architecture and it's the last PR before 1.0.0 RC phase

Copy link

changeset-bot bot commented Sep 30, 2025

🦋 Changeset detected

Latest commit: ea5afcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-native-bottom-tabs Major
@bottom-tabs/expo-template Major
@bottom-tabs/react-navigation Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okwasniewski okwasniewski force-pushed the feat/drop-old-arch branch 5 times, most recently from 24f9f7c to 502c796 Compare October 1, 2025 19:21
@okwasniewski okwasniewski marked this pull request as ready for review October 1, 2025 19:29
Copy link

cursor bot commented Oct 1, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 2.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@okwasniewski okwasniewski requested a review from Copilot October 1, 2025 19:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for the old React Native architecture (Paper) and transitions the library to only support the new architecture (Fabric) as a breaking change before the 1.0.0 RC phase.

Key changes:

  • Removed old architecture build configurations and Turbo tasks
  • Eliminated old architecture-specific code files and implementations
  • Consolidated Android view manager implementation by removing the old architecture layer

Reviewed Changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
turbo.json Removed build:android:fabric task configuration
packages/react-native-bottom-tabs/react-native-bottom-tabs.podspec Removed old architecture conditional logic and always include common subspec
packages/react-native-bottom-tabs/ios/TabViewProvider.swift Removed old architecture properties and parsing functions
packages/react-native-bottom-tabs/ios/RCTTabViewViewManager.mm Completely removed old architecture view manager
packages/react-native-bottom-tabs/ios/Events/*.swift Removed old architecture event classes
packages/react-native-bottom-tabs/android/src/oldarch/RCTTabViewManager.kt Removed old architecture Android manager
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabViewManager.kt Consolidated implementation by inlining old RCTTabViewImpl logic
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabViewImpl.kt Removed implementation class that was abstracted for old architecture
packages/react-native-bottom-tabs/android/build.gradle Hardcoded new architecture as always enabled
package.json Removed build:android:fabric script
apps/example/package.json Consolidated Android build scripts to only support new architecture
CONTRIBUTING.md Updated documentation to reflect new architecture only support
.github/workflows/ci.yml Removed separate CI jobs for old architecture builds
.changeset/breezy-camels-lead.md Added changeset documenting breaking change

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@okwasniewski okwasniewski merged commit 4b4e781 into main Oct 1, 2025
5 checks passed
@okwasniewski okwasniewski deleted the feat/drop-old-arch branch October 1, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant