fix: make sure everything works correctly on macOS #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d1fdfe6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compilation issues for macOS by adding platform-specific conditional compilation directives and handling macOS-specific differences in the React Native bottom tabs implementation.
Key changes:
- Added macOS conditional compilation guards to prevent iOS-only code from executing on macOS
- Updated type signatures to use cross-platform types (PlatformView instead of UIView)
- Added macOS-specific implementations and default values
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TabViewProvider.swift | Added macOS guards for backgroundColor setting and updated insertChild parameter type |
| TabViewProps.swift | Added macOS availability annotation and platform-specific MinimizeBehavior conversion |
| TabViewImpl.swift | Added macOS conditional compilation guards around iOS-specific appearance updates |
| TabBarFontSize.swift | Added macOS import and default font size handling |
| .changeset/busy-seals-relax.md | Added changeset documentation for the macOS fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes compilation issues for macOS.