Run unit tests under Windows #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…he nodejs ecosystem. I'm trying to set the file/dir as offline to simulate it being otherwise inaccessible.
…rshell in some brittle way, and it just doesn't appear feasible for the unreadable directory case. The other unreadable file case is covered.
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve file permission handling and path normalization in the node API modules to ensure unit tests run properly on Windows. Key changes include:
- Refactoring the file readability check in isNodeApiModule with a new helper function (isReadableSync) and improved error messaging.
- Adjustments to normalize module paths for cross-platform compatibility.
- Updates to unit tests to simulate changes in file permission behavior on Windows using fswin, plus the addition of a dedicated Windows test workflow.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react-native-node-api-modules/src/node/path-utils.ts | Enhanced file readability checking and path normalization for cross-platform support. |
| packages/react-native-node-api-modules/src/node/path-utils.test.ts | Added helper functions to simulate removal and restoration of read permissions on Windows. |
| packages/react-native-node-api-modules/package.json | Added fswin dependency for Windows file attribute management. |
| .github/workflows/check.yml | Introduced a Windows test job to run the adjusted test suite. |
kraenhansen
reviewed
May 23, 2025
packages/react-native-node-api-modules/src/node/path-utils.test.ts
Outdated
Show resolved
Hide resolved
kraenhansen
reviewed
May 24, 2025
packages/react-native-node-api-modules/src/node/path-utils.test.ts
Outdated
Show resolved
Hide resolved
kraenhansen
reviewed
May 24, 2025
kraenhansen
reviewed
May 24, 2025
kraenhansen
approved these changes
May 24, 2025
…t.ts Co-authored-by: Kræn Hansen <mail@kraenhansen.dk>
Co-authored-by: Kræn Hansen <mail@kraenhansen.dk>
Co-authored-by: Kræn Hansen <mail@kraenhansen.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to get some early visibility into pathing or other issues. should "just work" with this subset of tests.