Image Queue #18

jusbar23 · 2020-02-13T16:37:28Z

Allow users to queue multiple images locally or remote

tsheaff

I'd like to approve this, looks really strong. But I think you need to add the pod dependency, which is the only blocker. You'll also want to bump the version (major bump seems appropriate?)

I also and left a few nits on the code.

KenBurns/Classes/KenBurns.swift

tsheaff · 2020-02-22T04:24:05Z

KenBurns/Classes/KenBurns.swift

+
+        self.fetchImage(self.imageURLs!.read()!, placeholder: nil)
+
+        for _ in 0..<10 {


Not sure I understand where this magic number. 10 is coming from. Can you please explain, and also drop a comment here?

From my testing, I found that when the nextImage function is used there is a glitch that remote images might not be downloaded in time. 10 is an arbitrary number. Of course there are optimizations we could do to avoid this such as image compression, preloading, caching, etc. This is more of a temporary solution

KenBurns/Classes/KenBurns.swift

KenBurns/Classes/RingBuffer.swift

README.md

jusbar23 · 2020-02-22T09:05:27Z

Hi Tyler, thanks for taking the time to look at my PR. Going ahead to make the changes requested

tsheaff

Thanks for the changes.

Can you bump the version in the podspec to 0.4.0?

One final question before approving: I noticed from your gif that they're not cross-fading over one another. I haven't tried and run this myself. Does this ruin the cross-fade effect? That's an important part of this, and I would have expected, for example, Image 1 to gently fade out to reveal Image 2 behind, then Image 3 etc in a loop.

jusbar23 · 2020-02-22T16:04:22Z

Yes, thanks for pointing that out. Fixing that right now, give me a few!

Add ring buffer for smoothness Removed Copyright added GIF and removed SD Image GIF was too large Added demo, cleaned up code, updated gif, removed ringbuffer Increase GIF Size Reduced Size of GIF

jusbar23 · 2020-02-22T18:01:40Z

Changes made:

Updated GIF
Removed Ring Buffer for Image Views
Cleaned up code
Added Demo Project
Rebased

tsheaff · 2020-02-22T19:33:12Z

@justinbarnett1 merged to master and published to Cocoapods trunk:

➜  KenBurns git:(master) pod trunk push KenBurns.podspec
Updating spec repo `trunk`

CocoaPods 1.9.0.beta.3 is available.
To update use: `sudo gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information, see https://blog.cocoapods.org and the CHANGELOG for this version at https://github.com/CocoaPods/CocoaPods/releases/tag/1.9.0.beta.3

Validating podspec
 -> KenBurns (0.4.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'CalmParametricAnimations' from project 'Pods')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'Kingfisher' from project 'Pods')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'KenBurns' from project 'Pods')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'Pods-App' from project 'Pods')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'App' from project 'App')

Updating spec repo `trunk`

CocoaPods 1.9.0.beta.3 is available.
To update use: `sudo gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information, see https://blog.cocoapods.org and the CHANGELOG for this version at https://github.com/CocoaPods/CocoaPods/releases/tag/1.9.0.beta.3


--------------------------------------------------------------------------------
 🎉  Congrats

 🚀  KenBurns (0.4.0) successfully published
 📅  February 22nd, 11:31
 🌎  https://cocoapods.org/pods/KenBurns
 👍  Tell your friends!
--------------------------------------------------------------------------------

jusbar23 · 2020-02-22T19:45:47Z

Thank you! Just wondering are you guys hiring for PM? I’m based in FL but willing to relocate

Add Image Queue

da3d334

jusbar23 requested a review from tsheaff February 14, 2020 18:59

tsheaff suggested changes Feb 22, 2020

View reviewed changes

tsheaff mentioned this pull request Feb 22, 2020

Updating sdImageView Version #17

Closed

jusbar23 requested a review from tsheaff February 22, 2020 09:36

tsheaff reviewed Feb 22, 2020

View reviewed changes

Update ReadMe

6244f08

Add ring buffer for smoothness Removed Copyright added GIF and removed SD Image GIF was too large Added demo, cleaned up code, updated gif, removed ringbuffer Increase GIF Size Reduced Size of GIF

jusbar23 requested a review from tsheaff February 22, 2020 18:01

tsheaff approved these changes Feb 22, 2020

View reviewed changes

tsheaff merged commit 4c166ac into calm:master Feb 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Image Queue #18

Image Queue #18

jusbar23 commented Feb 13, 2020

tsheaff left a comment

tsheaff Feb 22, 2020

jusbar23 Feb 22, 2020

jusbar23 commented Feb 22, 2020

tsheaff left a comment

jusbar23 commented Feb 22, 2020

jusbar23 commented Feb 22, 2020

tsheaff commented Feb 22, 2020

jusbar23 commented Feb 22, 2020 •

edited

Loading


		self.fetchImage(self.imageURLs!.read()!, placeholder: nil)

		for _ in 0..<10 {

Image Queue #18

Image Queue #18

Conversation

jusbar23 commented Feb 13, 2020

tsheaff left a comment

Choose a reason for hiding this comment

tsheaff Feb 22, 2020

Choose a reason for hiding this comment

jusbar23 Feb 22, 2020

Choose a reason for hiding this comment

jusbar23 commented Feb 22, 2020

tsheaff left a comment

Choose a reason for hiding this comment

jusbar23 commented Feb 22, 2020

jusbar23 commented Feb 22, 2020

tsheaff commented Feb 22, 2020

jusbar23 commented Feb 22, 2020 • edited Loading

jusbar23 commented Feb 22, 2020 •

edited

Loading