Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add count to expect_compound_columns_to_be_unique #257

Closed
VDFaller opened this issue May 9, 2023 · 1 comment · Fixed by #261
Closed

[Feature Request] Add count to expect_compound_columns_to_be_unique #257

VDFaller opened this issue May 9, 2023 · 1 comment · Fixed by #261
Labels
enhancement New feature or request

Comments

@VDFaller
Copy link
Contributor

VDFaller commented May 9, 2023

Is your feature request related to a problem? Please describe.
Not really a problem. Just a nice to have and it mirrors features in the analogous test in dbt core.

Describe the solution you'd like
Just add a count probably here called n_records . Just to match dbt-core unique test

I'm happy to put in the MR if y'all think this is a reasonable thing.
@VDFaller VDFaller changed the title [Feature Request] Add count to [Feature Request] Add count to expect_compound_columns_to_be_unique May 9, 2023
@clausherther
Copy link
Contributor

Sounds like a good idea to me. Thanks!

@clausherther clausherther added the enhancement New feature or request label May 23, 2023
VDFaller added a commit to VDFaller/dbt-expectations that referenced this issue May 24, 2023
@VDFaller
calogica#257 Add count to expect_compound_columns_to_be_unique
326ee99
@VDFaller VDFaller mentioned this issue May 24, 2023
Merged
clausherther pushed a commit that referenced this issue May 24, 2023
@VDFaller
#257 Add count to expect_compound_columns_to_be_unique (#261)
6700bbc 
* #257 Add count to expect_compound_columns_to_be_unique

* move comma to end of line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#257 Add count to expect_compound_columns_to_be_unique VDFaller/dbt-expectations
2 participants
@VDFaller @clausherther