#257 Add count to expect_compound_columns_to_be_unique #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clausherther
requested changes
May 24, 2023
| @@ -39,6 +39,7 @@ with validation_errors as ( | |||
| {% for column in columns -%} | |||
| {{ column }}{% if not loop.last %},{% endif %} | |||
| {%- endfor %} | |||
| ,count(*) as {{adapter.quote("n_records")}} | |||
There was a problem hiding this comment.
slight nit: we do commas at the of lines in this repo, thanks!
There was a problem hiding this comment.
I assume you mean end. On it.
There was a problem hiding this comment.
Do you need me to rebase the commits?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue this PR Addresses/Closes
Closes #257
Summary of Changes
Just adds a
count(*) as n_recordsto expect_compound_columns_to_be_uniqueWhy Do We Need These Changes
Consistency between dbt-expectations and dbt-core uniqueness tests.
Reviewers
@clausherther