Repository navigation
v0.0.55
- Issue #104 (UI half): cold_api.yaml gains review_queue_by_reviewer, a paired by_reviewer (all-records) query, and get_all_reviewer_usernames for autocomplete; rdm_review_queue.ts gains a Reviewer column in the results table/CSV and matching search-dropdown options. DR-0026: pair by_reviewer with review_queue_by_reviewer for consistency with the other four search types even though only the review-queue case was originally requested, place the column directly after Submitted By, and back autocomplete with a new reviewer_usernames harvest field rather than parsing reviewer_names client-side
- rdm_requests_harvest_sql.bash gains reviewer_usernames, a JSON array alongside the existing reviewer_names string, needed only so cold_api.yaml can json_each over it for the autocomplete list. Backfilled with a second full re-harvest; the incremental picked it up automatically on its next tick, same as the harvest half
- Two real bugs found and fixed building get_all_reviewer_usernames, both in how SQLite's json_each interacts with datasetd's response encoding rather than in the query logic: json_each returns one NULL-valued row for a scalar JSON null instead of skipping it (fixed with a
value is not nullfilter), and json_each's raw scalar value isn't valid JSON on its own (fixed with json_quote()). Neither surfaced testing datasetd directly -- only through the real cold.ts -> datasetd request-mapping path (see cold observations 424-425) - rdm_review_queue.ts had no test coverage before this release. formatJsonAsHtmlTable, formatJsonAsCSV, genDownloadName and normalizeItem are now exported and covered by a new rdm_review_queue_test.ts (10 tests); genDownloadName was pulled out of its class since it never used
this run_authors_review_queue_csv.bashand its all-records siblingrun_authors_records_csv.bashgain areviewer_namesCSV column too, found missing during manual testing before release. These are separate report scripts fromrdm_review_queue.tsandcold_api.yaml-- each readsrdm_requests.dsdirectly viadsquerywith its own hand-picked column list -- so the earlier UI-half work did not touch them automatically- #104's reviewer column, paired search and autocomplete ship in this release (DR-0025/DR-0026), and so does the follow-up cycle answering its three remaining comments (DR-0027). #104 is now fully closed
- Title/publisher search is answered by wrapping every results table in a
<sortable-table>component -- built and tested earlier in a prior cycle, never wired into any page until now -- rather than adding dedicated search queries. Fed by a newreview_queue_browsequery, scoped to the review queue only, not "All Records" (111K+ rows -- too large a payload to load client-side for a title filter) - The live queue is split into its own page:
rdm_review_queue.htmlkeeps its name and becomes review-queue-scope only (plus the new browse-all entry); a newrdm_records.htmltakes over the old "All Records" search group - No default multi-column sort was added to
<sortable-table>; click-to-sort is sufficient given the SQL's own ordering - No pagination anywhere
<sortable-table>is used, includingrdm_records.html's already-large searches -- an explicit decision, not an oversight. RSDOIEL protested on engineering grounds and was overruled: Tom Morrell and the librarians who use this tool were consulted and chose to accept loading everything up front over adding pagination build.tshard-coded the same page_title for every generated htdocs/*.html page, discarding each page's own front-mattertitle:-- an accessibility defect under WCAG 2.4.2 Page Titled (cold#112). Now readsattrs.title, falling back to the old default only if a page has nonecodemeta.json'ssoftwareRequirementsno longer lists CMTools (cold#113) -- already fixed in commit a815d41 before this cycle started, closing the issue rather than reopening the work- The 16
htdocsbundle tasks (deno bundle --config tsconfig.json) now pass--lock=htdocs.lock, a separate lock file, instead of rewriting the maindeno.lockdown to just their own graph on every run -- a long-carried TODO.md item, fixed - Dashboard polish found during manual testing: the redundant "browse all submitted requests" link removed from
rdm_review_queue.htmlnow thatreview_queue_browseis a dropdown option too; the review-queue link relabeled "Search RDM Queue" and moved ahead of "Search RDM Records" (used more often); the Tools section split into two<ul>groups, search tools and other tools
Full Changelog: v0.0.54...v0.0.55