Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to bootstrap@5 on signup and landing #518

Merged
merged 5 commits into from May 10, 2021

Conversation

Priyaraj17
Copy link
Contributor

@Priyaraj17 Priyaraj17 commented May 8, 2021

Issue: #517

Summary

I have updated the version of bootstrap from 4.4.1 to 5.0.0.
WhatsApp Image 2021-05-08 at 11 48 56 AM

Motivation

The latest version of bootstrap is 5.0.0 and caMicrscope currently uses 4.4.1.
I also worked on improvement in the responsiveness of the application for the smaller screens. I added a few css styles to make the UI more attractive.

Testing

UI:
Desktop:
WhatsApp Image 2021-05-08 at 11 42 12 AM
I PhoneX
WhatsApp Image 2021-05-08 at 11 42 59 AM

Sign-Up page:
Smal screens:
WhatsApp Image 2021-05-08 at 11 47 05 AM

Questions

@Priyaraj17 Priyaraj17 changed the title Updated to bootstrap 5 Updated to bootstrap@5 May 8, 2021
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In signup, I'm seeing an issue with the viewer type selection box's style.

image

@Priyaraj17
Copy link
Contributor Author

I might have missed this. I will make the necessary changes. Thanks!

@Priyaraj17
Copy link
Contributor Author

Hey @birm, I have made the required changes.

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@birm birm changed the base branch from master to develop May 10, 2021 16:28
@birm birm merged commit f7cae88 into camicroscope:develop May 10, 2021
@birm birm changed the title Updated to bootstrap@5 Updated to bootstrap@5 on signup and landing May 10, 2021
@Priyaraj17
Copy link
Contributor Author

Thanks for the quick fix!

Happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants