Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload percent merged #164

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Upload percent merged #164

merged 8 commits into from
Apr 5, 2022

Conversation

mntxca
Copy link
Collaborator

@mntxca mntxca commented Apr 4, 2022

No description provided.

@gitguardian
Copy link

gitguardian bot commented Apr 4, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
2884049 Generic High Entropy Secret b3b91c8 terraform/ndfc/cluster_ndfc.tfvars View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@lgtm-com
Copy link

lgtm-com bot commented Apr 4, 2022

This pull request introduces 1 alert when merging b3b91c8 into b79a881 - view on LGTM.com

new alerts:

  • 1 for Unused import

@camrossi camrossi merged commit ee34961 into dev_1.0rc0 Apr 5, 2022
@camrossi camrossi deleted the upload_percent_merged branch May 8, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants