Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Zeebe client example from Zeebe repository #3

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Jun 7, 2022

see camunda/camunda#9500

This adds the examples currently living in Zeebe repo to this project. The idea is to consolidate all examples in one place.

@pihme
Copy link
Contributor Author

pihme commented Jun 7, 2022

I saw that the build failed, but I don't see a connection to this PR.

@berndruecker berndruecker merged commit 06cb6a2 into main Jun 14, 2022
@berndruecker
Copy link
Contributor

@pihme would you mind if I rename the folder where the example is located to indicate that this is about the "java" client specifically (as this project might also have other languages in the future)? Maybe simply zeebe-client-java?

@pihme
Copy link
Contributor Author

pihme commented Jun 21, 2022

@berndruecker If you are starved for time, do you want me to rename the folder? I am asking, because I want to know the name, so I can adjust the link in documentation and in the old Zeebe location.

@berndruecker
Copy link
Contributor

@pihme I was mainly waiting for some feedback if OK for you :-) I renamed it now: 49585d4 --> zeebe-client-plain-java

@berndruecker berndruecker deleted the move-zeebe-examples branch June 21, 2022 08:54
ghost pushed a commit to camunda/camunda that referenced this pull request Jun 23, 2022
9513: chore(samples): remove samples r=pihme a=pihme

## Description

Removes the samples from Zeebe Repo

## Related issues

closes #9500

## Depends on / Do not Merge before
* [x] camunda-community-hub/camunda-8-examples#3
* [x] camunda/camunda-docs#963



Co-authored-by: pihme <pihme@users.noreply.github.com>
ghost pushed a commit to camunda/camunda that referenced this pull request Jun 23, 2022
9513: chore(samples): remove samples r=pihme a=pihme

## Description

Removes the samples from Zeebe Repo

## Related issues

closes #9500

## Depends on / Do not Merge before
* [x] camunda-community-hub/camunda-8-examples#3
* [x] camunda/camunda-docs#963



Co-authored-by: pihme <pihme@users.noreply.github.com>
ghost pushed a commit to camunda/camunda that referenced this pull request Jun 23, 2022
9513: chore(samples): remove samples r=pihme a=pihme

## Description

Removes the samples from Zeebe Repo

## Related issues

closes #9500

## Depends on / Do not Merge before
* [x] camunda-community-hub/camunda-8-examples#3
* [x] camunda/camunda-docs#963



Co-authored-by: pihme <pihme@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants