-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roles <-> Groups #3
Comments
Hi Adrian, this Keycloak Identity Provider leaves the management of fine grained permissions to Camunda itself - see authorizations view in the Admin application. Thus it has the same behavior as the well-known LDAP Identity Provider Plugin: users and groups come from outside, the detailed permissions are managed in the application (Camunda) itself. For the time being, this design is intended. Cheers |
Hi Adrian, you also mentioned nested groups. A filter for only mapping groups within a certain part of a hierarchy could be a feature to be implemented in future. I strongly agree with that. Cheers |
@VonDerBeck I noticed this was removed from 1.3.0 milestone. Any idea when this will be added? |
Hi @gil0109, Unfortunately, I cannot give you a date at the moment. Since the plugin also works well with mass data the feature has a lower priority than other enhancements. |
Hi, after working with keycloak/OIDC for a longer time now, I think even more, that the roles approach would be the "right" one. |
Thanks! That is certainly true. However, it is difficult to transfer this to the general public. Some customers simply use the LDAP User Federation to import their users and groups into Keycloak. And that's it. If the administration effort and the amount of indirections and mappings increases, you will probably lose some plugin users. Therefore, the simplest possible straight forward approach is the one that covers the mass of use cases. Maybe it is worthwhile to do a survey among the users at some point. |
Hello Gunnar (@VonDerBeck), First of all I would congratulate you as this Plug-In work brilliantly. Now, in last few days I went through this discussion multiple times. We have a setup where we have multiple applications which depend upon Keycloak and some of these applications depend upon Camunda BPM. Users for all applications come from a federated organizational user database. Considering this scenario, I side with Adrian (@adrianschneider94) little bit more that Keycloak roles are probably more relevant unit for authorization in Camunda. But at the same time, there can be process applications which may want to take advantage of the groups. For example, I can design a process which can only be started by role for instance It is irrelevant which of the two are used for Camunda authorizations. This is semantic difference which users should sort out. My two cents... Thanks and Regards |
Hi @chaitanyabjoshi, @adrianschneider94, In order to implement this without creating a big mess and performance issues within the Identity Provider we sadly have to wait for some Keycloak Features, e.g.
This is all about a more powerful query api focussing on (client) roles and their users, whether associated directly or indirectly. Both are currently on hold, but labeled for Keycloak 11.0.0. Once these features are stable and included in Keycloak, I hope that the implementation of an optional "Keycloak role mode" for the Identity Provider might well be possible. Thanks for your valuable input. |
For theses 2 MR if someone want to help to improve them he can, we have to change the wording for parents of a role and also there is a risk a requesting the whole database with KEYCLOAK-11494 ( we need to put some restriction/limitation. Also for reviewing and suggestion I can in few days apply changes on theses MR. We are using them on production since 6 month without any issues. |
I'm a bit confused, because I thought, that one cannot retrieve the effective client roles of a user. However I'm doing that in my project right now with the |
Retrieving the effetive roles of a single user - ok, done, but sadly this is only one aspect. Have you thought about querying the other way around? Get all users who have an effective given client role? Including indirection over groups, composite roles etc.? The endpoint This may work in special scenarios when directly assigning users to client roles, but is far too little for a generally applicable approach. |
@VonDerBeck Thank you for your help 👍 |
hello dear community, I created new user for my process which I modeled with CAMUNDA. the problem is that I cannot connect with these created users. could someone help me please? I am new to modeling bpmn processes |
Hi @Traore57, Are you using the Keycloak Identity Provider Plugin? If yes, what exactly do you mean by "I cannot connect with these created users"? |
Unfortunately @VonDerBeck is right - as long as we can’t get users from a role we have to use groups. And I can think of some cases where we need to know who is a member of a camunda group. Roles (client, realm, composite) where user are either directly assigned that role or by a group can get pretty complex. And as @Cracky5457 mentioned there are some performance impacts. On the other hand I totally agree with @adrianschneider94 , @chaitanyabjoshi - using roles makes it easy to isolate camunda-specific stuff in keycloak. Of course one could do some filtering - just read groups from keycloak that have a prefix for example. But that is just cosmetics . What comes to my mind is this (don’t know if that works at all) Have a read-only user store that syncs with keycloak . But the groups(and group memberships) will be maintained in camunda. And as a bonus the groups will be synced TO keycloak as client-roles, and are available for other clients. that might work in smaller deployments, but gets bad when users/groups grow. I might go for the filter ;-) I am currently reworking my keycloak-sso extension and might provide a PR if you don’t mind. It still means some extra work for service-account-clients but we can‘t have it all unfortunately. |
Reading through the
Find those here https://www.keycloak.org/docs-api/11.0/rest-api/index.html Am I missing something from the bigger picture? Probably some part about the effective users. |
Hey @tmaroschik, that‘s what @VonDerBeck pointed out here: You just get the directly assigned users, not the effective users in this role. So any role mapping or sth. similar wouldn‘t have any effect. |
Hi,
as far as I understand it, groups are just for managing users in Keycloak whereas roles are for managing permissions. (Group people in Groups, grant different groups different sets of roles).
But on the other hand you can have nested groups but not nested permissions in keycloak. Nested groups would be very handy to not map all keycloak groups into camunda but just the relevant ones.
As you see I don't have a settled opinion on this but I think it's worth discussing.
Best wishes,
Adrian Schneider
The text was updated successfully, but these errors were encountered: