Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate CalledElement#propagateAllParentVariables #124

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

romansmirnov
Copy link
Member

closes #123

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 24, 2023
@romansmirnov romansmirnov marked this pull request as ready for review August 24, 2023 12:55
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 24, 2023
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid implementation + test coverage, thank you!

@nikku nikku merged commit 44a6cf1 into main Aug 24, 2023
2 checks passed
@nikku nikku deleted the 123-no-prop-variables branch August 24, 2023 13:12
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 24, 2023
@philippfromme
Copy link
Collaborator

Great! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation rule for CalledElement#propagateAllParentVariables
3 participants