Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Manage Connector Templates" docs #3420

Merged
merged 20 commits into from
Apr 26, 2024
Merged

Add "Manage Connector Templates" docs #3420

merged 20 commits into from
Apr 26, 2024

Conversation

YanaSegal
Copy link
Contributor

@YanaSegal YanaSegal commented Mar 6, 2024

As part of https://github.com/camunda/product-hub/issues/1340 I am suggesting the following updates and changes for this page.

  • Add docs describing Shared Resources tab in SaaS web-modeler
  • Clarify existing docs about Connector templates shared with an organization

Closes https://github.com/camunda/team-connectors/issues/660

Description

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.
  • This functionality will be available within the next week (in next web-modeler SaaS release), but we'd like documentation available at launch

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

As part of camunda/product-hub#1340 I am suggesting the following updates and changes for this page.
@YanaSegal YanaSegal added the component:connectors Issues related to the connectors project. label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/connectors/img/connector-templates/manage-connector-templates-no-org-privileges.png
  • docs/components/connectors/img/connector-templates/manage-connector-templates-org-privileges.png
  • docs/components/connectors/manage-connector-templates.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@YanaSegal
Copy link
Contributor Author

@ev-codes I submitted my text changes. we still need to add the "Shared resources" screenshot.

as a stretch goal - we can update all screenshots on this page to be up-to-date.


![Publishing a template](img/connector-templates/create-connector-template-3.png)

When using the Camunda 8 SaaS offering, as [organization owner or admin](/components/console/manage-organization/manage-users.md#users) you can publish a template version to the organization making it available to all projects in the organization.
To do so, either click **Publish > Publish to organization** on the Connector template editor screen or promote a template via the [Version History](#versioning-connector-templates).
As [organization owner or admin](/components/console/manage-organization/manage-users.md#users), you can publish a Connector template version within the organization context, enabling all organization members to use it in their diagrams.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
As [organization owner or admin](/components/console/manage-organization/manage-users.md#users), you can publish a Connector template version within the organization context, enabling all organization members to use it in their diagrams.
As [organization owner or admin](/components/console/manage-organization/manage-users.md#users), you can publish a Connector template version within the organization context, enabling all organization members to use it in their diagrams.

Comment on lines 46 to 47
![Promoting a template](img/connector-templates/create-connector-template-4.png)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
![Promoting a template](img/connector-templates/create-connector-template-4.png)
![Promoting a template](img/connector-templates/create-connector-template-4.png)

:::info Publishg to the organization is available for Camunda 8 SaaS only. :::

### Manage published Connectors
After publishing, a Connector template version can be applied across all models within the same project or organization, depending on its publication status. You can review the publication status of template versions in the [Version History](#versioning-connector-templates).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
After publishing, a Connector template version can be applied across all models within the same project or organization, depending on its publication status. You can review the publication status of template versions in the [Version History](#versioning-connector-templates).
After publishing, a Connector template version can be applied across all models within the same project or organization, depending on its publication status. You can review the publication status of template versions in the [Version History](#versioning-connector-templates).

Comment on lines 53 to 54
On the modeler home page, you can find an overview of all shared resources within your organization.
Members without special permissions can view all the resources published within the organization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
On the modeler home page, you can find an overview of all shared resources within your organization.
Members without special permissions can view all the resources published within the organization.
On the modeler home page, you can find an overview of all shared resources within your organization.
Members without special permissions can view all the resources published within the organization.

@christinaausley
Copy link
Contributor

@YanaSegal Will this go out with release next week?

@YanaSegal
Copy link
Contributor Author

@christinaausley I guess not as the epic is not making it to the 8.5 release.

@YanaSegal
Copy link
Contributor Author

@akeller / @christinaausley
Reviewing the links of the "Versioning Connector templates" section exposes:

  • this document lives in Connectors
  • The link to Milestone points to web modeler documentation about milestones, but it does not mention the JSON editor milestones.
  • The link to "updating the version" redirects to desktop modeler documentation. but the feature we are adding is for SAAS only.

I don't have a solution but I wanted to highlight this issue.
Screenshot:
Screenshot 2024-04-15 at 3 31 42 PM

@akeller
Copy link
Member

akeller commented Apr 15, 2024

@YanaSegal this looks like feedback @ev-codes would implement in this PR. Or are you asking for assistance from DevEx?

If I'm following your comments correctly, we can add a SaaS-only badge. However, everything outside of the Self-Managed section is SaaS-first.

@YanaSegal
Copy link
Contributor Author

YanaSegal commented Apr 16, 2024

Or are you asking for assistance from DevEx?

@akeller I am asking for your support as the links in the section I mentioned do not directly mention connectors or the editor. i think users that working on SaaS only, will be confused with seeing desktop modeler docs.
This is not blocking us, but makes sense to review it.

The "shared resources" feature is currently for SaaS only, but this may change in the future.

@ev-codes
Copy link
Contributor

ev-codes commented Apr 16, 2024

@christinaausley may you please take a look at the docs in this PR?

This feature (and these docs) still need to go through the Connectors QA process before I merge, but I'd appreciate you taking a look before the QA process starts.

After your review (and I implement your suggestions), I will:

  1. Start (and eventually complete) the QA process for this feature
  2. Merge the feature into Web Modeler
  3. Remove the "hold" label from this PR and merge after your approval

@ev-codes ev-codes added the hold This issue is parked, do not merge. label Apr 16, 2024
@ev-codes ev-codes marked this pull request as ready for review April 16, 2024 13:53
@ev-codes ev-codes removed the hold This issue is parked, do not merge. label Apr 16, 2024
@christinaausley
Copy link
Contributor

@ev-codes @YanaSegal This is wonderfully written! Some very small changes in my latest commits, but has my approval.

@christinaausley
Copy link
Contributor

This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?

Shall we apply a hold label until this is ready for final approval?

@ev-codes
Copy link
Contributor

@christinaausley Sure, I'll add the hold label now!

I had added one before, but removed it because it caused the "Enforce PR labels" check to fail.

@ev-codes ev-codes added the hold This issue is parked, do not merge. label Apr 19, 2024
@christinaausley
Copy link
Contributor

@christinaausley Sure, I'll add the hold label now!

I had added one before, but removed it because it caused the "Enforce PR labels" check to fail.

Yeah, this is intentional so things don't get accidentally merged. We can remove and it will build clean once we are ready to merge this in 👍

@ev-codes ev-codes removed the hold This issue is parked, do not merge. label Apr 26, 2024
@ev-codes ev-codes changed the title Update manage-connector-templates.md Add "Manage Connector Templates" docs Apr 26, 2024
@ev-codes
Copy link
Contributor

@christinaausley this PR is fully ready now - may you please approve?

The code has been merged into web-modeler and should be released to SaaS customers sometime next week.

Since a link to this doc is prominently featured in the UI, I'd love to have these docs already available before the SaaS release if possible 😄

@christinaausley christinaausley merged commit 220f07c into main Apr 26, 2024
8 checks passed
@christinaausley christinaausley deleted the YanaSegal-patch-1 branch April 26, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants