Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File type not re-checked upon reload #2279

Open
falko opened this issue May 20, 2021 · 10 comments
Open

File type not re-checked upon reload #2279

falko opened this issue May 20, 2021 · 10 comments
Labels
backlog Queued in backlog bug Something isn't working Camunda 8 Flags an issue as related to Camunda 8

Comments

@falko
Copy link
Member

falko commented May 20, 2021

Describe the Bug

The attached model is still detected as 'Camunda Platform' although it explicitely defines modeler:executionPlatform="Camunda Cloud"

Steps to Reproduce

  1. Open this file customer_onboarding_en.bpmn.txt
  2. Status bar shows 'Camunda Platform'

Expected Behavior

Status bar shows 'Camunda Cloud'

Environment

  • OS: Kubuntu 20.04.2 LTS
  • Camunda Modeler Version: 4.9.0-nightly.20210518
  • Execution Platform: Camunda Cloud
  • Installed plug-ins: Cloud Connect

Related to #2283.

@falko falko added the bug Something isn't working label May 20, 2021
@falko
Copy link
Member Author

falko commented May 20, 2021

I introduced the execution platform attribute via sed -i 's#xmlns:camunda="http://camunda.org/schema/1.0/bpmn"#xmlns:camunda="http://camunda.org/schema/1.0/bpmn" xmlns:zeebe="http://camunda.org/schema/zeebe/1.0" xmlns:modeler="http://camunda.org/schema/modeler/1.0" modeler:executionPlatform="Camunda Cloud" modeler:executionPlatformVersion="1.0.0"#g' *.bpmn and that worked fine for other files.

@falko
Copy link
Member Author

falko commented May 20, 2021

Okay, now it worked for me after I closed the file and opened it again using the open file dialogue. It seems like the reload after the file got modified externally as well as closing the file and then 'reopen last file' do not check for the platform again.

@pinussilvestrus
Copy link
Contributor

Yes, we are checking for the platform only on file opening (when we retrieve the correct tab type for the diagram). Makes sense to maybe do the checks way more often.

@falko
Copy link
Member Author

falko commented May 21, 2021

Yes, please ;-)

@falko
Copy link
Member Author

falko commented May 21, 2021

Well, you might as well fix the root cause and have an easy way to open Zeebe Modeler and Cawemo files as Camunda Cloud files or have an easy way to switch as discussed in #2283

@nikku
Copy link
Member

nikku commented May 25, 2021

@pinussilvestrus How complicated would #2279 (comment) be?

@pinussilvestrus
Copy link
Contributor

It's not trivial. Our checkFileChanged handler is currently assuming the type of the tab did not change. We would have to break this up and recreate the tab if necessary.

@nikku nikku added the Camunda 8 Flags an issue as related to Camunda 8 label May 25, 2021
@nikku nikku added the backlog Queued in backlog label Jun 1, 2021
@nikku
Copy link
Member

nikku commented Jun 1, 2021

We'll address the root cause of this issue by removing the + button, at least temporarily.

@falko
Copy link
Member Author

falko commented Jun 4, 2021

The + button was not the root cause of this issue. This model has been migrated from Camunda Platform to Camunda Cloud. Models exported from Cawemo for use with Camunda Cloud face similar issues.

A better solution for switching the execution platform as discussed in #2283 or an actual migration of models without external tools would prevent this issue.

@berndruecker
Copy link
Member

Could we rename this issue to "File type should be re-checked upon reload" to sort out the different problems?

Even the "Reopen last file" does not do a fresh check. This is pretty confusing in this context.
I also face this problem when applying my little cloud -> platform migration plugin.

@nikku nikku changed the title Model still detected as 'Camunda Platform' although modeler:executionPlatform="Camunda Cloud" File type not re-checked upon reload Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working Camunda 8 Flags an issue as related to Camunda 8
Projects
None yet
Development

No branches or pull requests

4 participants