Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flags.json accessible from option menu #3467

Open
christian-konrad opened this issue Feb 15, 2023 · 6 comments
Open

Make flags.json accessible from option menu #3467

christian-konrad opened this issue Feb 15, 2023 · 6 comments
Labels
backlog Queued in backlog channel:support enhancement New feature or request

Comments

@christian-konrad
Copy link
Contributor

christian-konrad commented Feb 15, 2023

Problem you would like to solve

The flags.json is an important place for some settings, for example to configure the path to an SSL certificate to connect to a self-managed Zeebe installation. However, users don't know it exist, what it is used for, and how to configure it, until they read the documentation.

Proposed solution

Have an Settings entry in the Desktop Modeler menu (toolbar and/or tab context menu) that opens the flags.json in an (external? OS default?) editor.

Cf. how it works in Windows Terminal:

https://learn.microsoft.com/en-us/windows/terminal/customize-settings/profile-general

image

Alternatives considered

Provide a full-fledged settings page in Desktop Modeler. But that should be a future iteration.

Additional context

Cf. https://jira.camunda.com/browse/SUPPORT-15806


Depends on #2913

@nikku
Copy link
Member

nikku commented Feb 15, 2023

Is this a duplicate of #2913? I absolutely agree that this is worth tackling at some point.

@nikku nikku added the help wanted Extra attention is needed label Feb 15, 2023
@christian-konrad
Copy link
Contributor Author

@nikku #2913 is the full-fledged solution.
However, this is a first increment.

Cf. how it was done in Windows Terminal (I linked it above).
They started with the settings.json opened via the settings menu, and later added an UI on top

@nikku nikku added ready Ready to be worked on and removed help wanted Extra attention is needed labels Feb 16, 2023
@nikku nikku changed the title Make flags.json accessible from option menu Make flags.json accessible from option menu Feb 16, 2023
@nikku
Copy link
Member

nikku commented Feb 16, 2023

We currently have different files:

  • one settings, containing both internal (app storage) and user entered configuration
  • one flags file that may live in different places in the operating system

I think we should invest into a simple settings dialog instead of exposing all these files through the menu.

@christian-konrad
Copy link
Contributor Author

@nikku how feasible is it to start implementing #2913 ?

We can be super agile here and just add more and more options to the page.
Every option exposed in the UI instead of the jsons will add value to it.

The dialog could then also start with a section saying "every other option can be specified in JSON files. Read the docs to understand what and where etc"

@nikku
Copy link
Member

nikku commented Feb 16, 2023

@christian-konrad I agree.

Let's keep it very basic to start with, and add more as we see the need. Starting basic with a setting stab is absolutely feasible. For now the pressing issue is "access to startup flags" (and/or related configuration). ➡️ #2913 (comment).

@CatalinaMoisuc
Copy link
Member

CatalinaMoisuc commented Feb 21, 2023

I suggest that we validate with the customer if the solution that @nikku proposed in the support ticket would actually be a better and simpler option to solve their problem.

That being said, I suggest that we don't prioritize this yet, but @christian-konrad you support us with getting in touch with the customer to validate if the solution mentioned above would lead to a better result and user experience for the customer.

@CatalinaMoisuc CatalinaMoisuc added backlog Queued in backlog and removed ready Ready to be worked on labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog channel:support enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants