Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use external align-to-origin util #1186

Merged
merged 6 commits into from
Feb 12, 2019
Merged

Use external align-to-origin util #1186

merged 6 commits into from
Feb 12, 2019

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 11, 2019 •
edited
Loading

This is a follow up to #1170.

  • use external align-to-origin util
  • disable move-to-origin feature if automatic alignment is configured

Closes #1183

@ghost ghost assigned nikku Feb 11, 2019
@ghost ghost added the needs review Review pending label Feb 11, 2019
@nikku nikku mentioned this pull request Feb 11, 2019
Closed
@nikku nikku changed the title Use external adjust-origin util Use external align-to-origin util Feb 12, 2019
@nikku
chore(client): use external align-to-origin util
0392c69 
* applies improved adjustment logic and more sane
  defaults for padding / offset

Related to #982
@nikku
feat(menu): disable move-to-origin per default
d67f4b7 
* only enabled when automatic adjustment is disabled
  via feature toggle

Related to #982
@nikku
chore(app): rename fix-origin to adjust-origin
8906c8c 
We don't really fix anything here.

Related to #982
@nikku
chore(app): update default diagrams
e27af7f 
* ensure default diagrams don't trigger origin update

Related to #982
@nikku
chore(app): bump dependency versions
7dd64b7
@nikku
Copy link
Member Author

nikku commented Feb 12, 2019

Ready for review 🤓

@nikku
Copy link
Member Author

nikku commented Feb 12, 2019

Closes #1183

pinussilvestrus
pinussilvestrus suggested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not remove the ID placeholder.

client/src/app/tabs/dmn/diagram.dmn Outdated Show resolved Hide resolved
@pinussilvestrus pinussilvestrus added ready Ready to be worked on and removed needs review Review pending labels Feb 12, 2019
@ghost ghost added needs review Review pending and removed ready Ready to be worked on labels Feb 12, 2019
@nikku
Copy link
Member Author

nikku commented Feb 12, 2019

Ready for second review round 🐎.

pinussilvestrus
pinussilvestrus reviewed Feb 12, 2019
View reviewed changes
client/src/app/tabs/bpmn/__tests__/DiagramSpec.js
@@ -0,0 +1,16 @@
describe('tabs/bpmn', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤

pinussilvestrus
pinussilvestrus approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works fine 👍

@merge-me merge-me bot merged commit 90eef29 into master Feb 12, 2019
@ghost ghost removed the needs review Review pending label Feb 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the adjust-origin-external branch February 12, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @pinussilvestrus