-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to connect to Zeebe with a custom certificate #3046
Conversation
I just discovered that when we use system certificates, one cannot connect to C8 SaaS anymore 🤡 |
OK so this is probably because we only fetch some of the certificates. Cf. https://github.com/jfromaniello/mac-ca/blob/master/index.js#L12 <- this part is missing in VSCode, and consequently our implementation. |
65fafd6
to
46e4afc
Compare
We need manual tests for each of the platforms (Linux, Windows, Mac):
For self-hosted, you can use scripts from https://github.com/barmac/zeebe-tls-connection-test |
I am moving this to |
d703d7c
to
d0d9bc0
Compare
d0d9bc0
to
8d49ab3
Compare
This is now ready for review. |
We had a meeting about this in which @CatalinaMoisuc suggested we cross link from the flag documentation to the self-managed self-signed certificate docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and clean. Thanks for looking into this.
This closes an issue that numerous people came across in C7 already. Good job fixing it (for the future) :).
Just for clarification, this is fixed for C8 only. We could fix it for C7 as well, as a separate topic. |
I tested it on linux and I can connect to all distos (SaaS, local TLS, local insecure). Thank you for the setup repo, this helped a lot 👏 |
I was able to test this on Windows. Steps
Works on Windows ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on all platforms, works for me 👍.
OK so I will merge this and we still need to update the documentation. |
de9ca74
to
d7457de
Compare
Done via camunda/camunda-docs#1268 |
This adds a flag for custom SSL certificate:
--zeebe-ssl-certificate=<path-to-file>
.Protocol http(s) is now required for the contact points of self-hosted Zeebe instances.
Closes #3028
How to test this in action
Prerequisites
Steps
npm run cert
. This will generatecert.pem
file which will be our certificate. Note that you may need to adjust thegenerate-cert.sh
file, namely the/usr/local/opt/openssl/bin/openssl
part to work on your OS. This is done specifically for MacOS.npm run zeebe
in a separate terminal window. This will run locally a Zeebe instance which will use the certificate for SSL.Flag
Run Camunda Modeler with flag
--zeebe-ssl-certificate=<path-to-cert.pem>
, and try to deploy and start instance of self-managed C8. Usehttps://localhost:26500
as the contact point.System keychain
After the flag part succeeds, add the certificate to the system keychain and make sure to mark it as trusted. Then, run Camunda Modeler with the flag, and try to deploy and start instance as in the previous part.