Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeler 5.0 doesn't show multi-line fields for scripts anymore #2982

Closed
michaelarnauts opened this issue Jun 1, 2022 · 11 comments · Fixed by #4429
Closed

Modeler 5.0 doesn't show multi-line fields for scripts anymore #2982

michaelarnauts opened this issue Jun 1, 2022 · 11 comments · Fixed by #4429
Assignees
Labels
bug Something isn't working developer productivity Everything related to improving the developer productivity (both efficiency and effectiveness) good first issue Good for newcomers properties panel ux
Milestone

Comments

@michaelarnauts
Copy link
Contributor

Describe the bug

The rework of the property panels in 5.0 doesn't support multi-line property fields anymore. This is needed when writing a script to be executed by a script worker (on Camunda Platform 8), or when working with JSON values.

Steps to reproduce

  1. Add a script task.
  2. Give it type script so it can be picked up by https://github.com/camunda-community-hub/zeebe-script-worker for example.
  3. Add a header language = javascript.
  4. Add a header script and try to add a script there. There is only room for one line.

image

image

Expected behavior

It should be possible to expand the input field so it can contain multi-line values. This is how it worked in Modeler 4.x and earlier.

Environment

  • OS: Ubuntu 22.04
  • Camunda Modeler Version: 5.0
  • Execution Platform: N/A (happens with Camunda Platform 7 and 8 BPMN files)
  • Installed plug-ins: N/A

Additional context

No response

@michaelarnauts michaelarnauts added the bug Something isn't working label Jun 1, 2022
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Jun 2, 2022

Thanks for your request!

The rework of the property panels in 5.0 doesn't support multi-line property fields anymore

The properties panel still supports multi line fields, for example Camunda Forms configuration

image

Headers are one-line inputs, that was already the case in Camunda Modeler 4.x

image

I think this is intended, as the docs don't describe the option for multi-line values.

If you think this would be a valuable addition, let's make this one a feature request and discuss it 👍

/cc
@christian-konrad

@pinussilvestrus pinussilvestrus added PM help wanted Extra attention is needed labels Jun 2, 2022
@christian-konrad
Copy link
Contributor

@michaelarnauts What is your use case of adding a script to the header?

@michaelarnauts
Copy link
Contributor Author

It seems to be the way how it's implemented in https://github.com/camunda-community-hub/zeebe-script-worker

Also, there is no other field available in models for Camunda 8.

@irlaer
Copy link

irlaer commented Jun 9, 2022

I have the same problem with editing names of elements
изображение

@marstamm
Copy link
Member

@irlaer , I believe this is a slightly different issue (name vs. script fields). I created bpmn-io/bpmn-js-properties-panel#705 to track the Name issue

@marstamm marstamm changed the title Modeler 5.0 doesn't show multi-line fields anymore Modeler 5.0 doesn't show multi-line fields for scripts anymore Jun 13, 2022
@nikku
Copy link
Member

nikku commented Jul 11, 2022

I think this is something we want to have (again), some day. Moving to backlog.

@nikku nikku added backlog Queued in backlog and removed help wanted Extra attention is needed labels Jul 11, 2022
@nikku
Copy link
Member

nikku commented Jul 11, 2022

CC @christian-konrad

@nikku nikku added ux spring cleaning Could be cleaned up one day modeling developer productivity Everything related to improving the developer productivity (both efficiency and effectiveness) properties panel and removed modeling PM labels Jul 11, 2022
@nikku nikku added the fixed upstream Requires integration of upstream change label Feb 3, 2023 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Feb 3, 2023
@nikku
Copy link
Member

nikku commented Feb 3, 2023

Improved upstream via bpmn-io/bpmn-js-properties-panel#705.

@michaelarnauts
Copy link
Contributor Author

Fixed upstream via bpmn-io/bpmn-js-properties-panel#705.

Only for name field, not for the headers or field injections.

@nikku nikku added backlog Queued in backlog and removed fixed upstream Requires integration of upstream change labels Feb 3, 2023
@nikku
Copy link
Member

nikku commented Feb 3, 2023

Thanks @michaelarnauts.

Removed fixed upstream. Would be a good candidate to now clean this up end-to-end. We have all foundations in place.

@nikku nikku added pr welcome We rely on a community contribution to improve this. good first issue Good for newcomers labels Dec 21, 2023
@jarekdanielak jarekdanielak self-assigned this Jul 4, 2024
@jarekdanielak
Copy link
Contributor

jarekdanielak commented Jul 22, 2024

Fixed upstream with bpmn-io/bpmn-js-properties-panel#1065

Released in bpmn-js-properties-panel@5.18.1

@jarekdanielak jarekdanielak added fixed upstream Requires integration of upstream change and removed backlog Queued in backlog pr welcome We rely on a community contribution to improve this. spring cleaning Could be cleaned up one day labels Jul 22, 2024
jarekdanielak added a commit to camunda/camunda-bpmn-js that referenced this issue Jul 23, 2024
jarekdanielak added a commit that referenced this issue Jul 23, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jul 23, 2024
nikku pushed a commit that referenced this issue Jul 24, 2024
@nikku nikku closed this as completed in 3e7a394 Jul 24, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 24, 2024
@github-actions github-actions bot modified the milestone: M79 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working developer productivity Everything related to improving the developer productivity (both efficiency and effectiveness) good first issue Good for newcomers properties panel ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants