Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] allow to set revisionHistoryLimit #1815

Open
helmecke-nlb opened this issue May 17, 2024 · 1 comment
Open

[ENHANCEMENT] allow to set revisionHistoryLimit #1815

helmecke-nlb opened this issue May 17, 2024 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@helmecke-nlb
Copy link

Describe the use case:

We are using ArgoCD and old replicaset only clutter the interface without any benefit. If we were able to set revisionHistoryLimit to "0" for deployments, replicasets without any pods would be removed.

Describe the enhancement/feature:

Add the following values to the values.yaml and render them into the corresponding Deployment spec.

connectors.revisionHistoryLimit: 10
console.revisionHistoryLimit: 10
identity.revisionHistoryLimit: 10
operate.revisionHistoryLimit: 10
optimize.revisionHistoryLimit: 10
tasklist.revisionHistoryLimit: 10
webModeler.restapi.revisionHistoryLimit: 10
webModeler.webapp.revisionHistoryLimit: 10
webModeler.websockets.revisionHistoryLimit: 10
zeebeGateway.revisionHistoryLimit: 10

Desired outcome and acceptance tests:

revisionHistoryLimit in every Deployment can be set via values.yaml.

@helmecke-nlb helmecke-nlb added the kind/enhancement New feature or request label May 17, 2024
@aabouzaid
Copy link
Member

@helmecke-nlb Thanks for the suggestion.
Currently, we are considering providing users a generic way to define any extra config they need.
Probably this will be part of the 8.6 release in October (maybe also before it).

@aabouzaid aabouzaid added this to the 8.6 Release Cycle milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants