Partition scoped components can register as DiskSpaceUsageListener #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, adding and removing a disk space usage listener was implemented directly by the broker context and the partition manager only had a callback to add usage listeners. Since we now want to add partition scoped components as disk space usage listeners directly, the `DiskSpaceMonitor` is made available in the `PartitionTransitionContext`.
deepthidevaki
requested changes
Jul 6, 2022
lenaschoenburg
force-pushed
the
9712-disk-space-usage-partition-components
branch
from
80e8023
to
699ddd7
Compare
|
Thanks @deepthidevaki, fixed the test setup 👍 |
|
bors r+ |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, adding and removing a disk space usage listener was implemented directly by the broker context and the partition manager only had a callback to add usage listeners.
Since we now want to add partition scoped components as disk space usage listeners directly, the
DiskSpaceMonitoris made available in thePartitionTransitionContext.I couldn't adjust the
ZeebePartitionto not awkwardly forward thenoDiskAvailableflag to the stream processor because the StreamProcessor can't be aDiskSpaceUsageListeneritself due to circular dependencies between broker and engine.This unblocks #9625 and closes #9712