Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(importer): prevent OOM by filtering out older process versions early on #2038

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

chillleader
Copy link
Member

Description

We need to filter out older process definitions versions at an earlier stage to prevent storing all process definitions in a list which may lead to an OOM error when there are too many processes deployed.

Related issues

closes https://github.com/camunda/team-connectors/issues/647

@chillleader chillleader self-assigned this Feb 27, 2024
@chillleader chillleader requested a review from a team as a code owner February 27, 2024 18:11
Copy link
Contributor

@igpetrov igpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chillleader chillleader added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 6713bd7 Mar 5, 2024
10 checks passed
@chillleader chillleader deleted the team-connectors/647-oom-in-operate-importer branch March 5, 2024 14:31
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-2038-to-release/8.3 origin/release/8.3
cd .worktree/backport-2038-to-release/8.3
git switch --create backport-2038-to-release/8.3
git cherry-pick -x 6713bd7010cbd93ca7276d95b91baa034c872f25

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-2038-to-release/8.4 origin/release/8.4
cd .worktree/backport-2038-to-release/8.4
git switch --create backport-2038-to-release/8.4
git cherry-pick -x 6713bd7010cbd93ca7276d95b91baa034c872f25

chillleader added a commit that referenced this pull request Jun 17, 2024
…rly on (#2038)

* fix(importer): prevent oom by filtering out older process versions early on

* fix tests

(cherry picked from commit 6713bd7)
chillleader added a commit that referenced this pull request Jun 17, 2024
…rly on (#2038)

* fix(importer): prevent oom by filtering out older process versions early on

* fix tests

(cherry picked from commit 6713bd7)
chillleader added a commit that referenced this pull request Jun 17, 2024
…rly on (#2038)

* fix(importer): prevent oom by filtering out older process versions early on

* fix tests

(cherry picked from commit 6713bd7)
chillleader added a commit that referenced this pull request Jun 17, 2024
…rly on (#2038)

* fix(importer): prevent oom by filtering out older process versions early on

* fix tests

(cherry picked from commit 6713bd7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants