-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka): migrate kafka inbound connectors to template generator #2250
Merged
Oleksiivanov
merged 3 commits into
main
from
689-migrate-kafka-inbound-connectors-to-element-template-generator
Apr 4, 2024
Merged
feat(kafka): migrate kafka inbound connectors to template generator #2250
Oleksiivanov
merged 3 commits into
main
from
689-migrate-kafka-inbound-connectors-to-element-template-generator
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuettner
reviewed
Mar 27, 2024
sbuettner
reviewed
Mar 27, 2024
Oleksiivanov
force-pushed
the
689-migrate-kafka-inbound-connectors-to-element-template-generator
branch
from
April 3, 2024 12:21
0c96044
to
77382e4
Compare
Oleksiivanov
force-pushed
the
689-migrate-kafka-inbound-connectors-to-element-template-generator
branch
from
April 3, 2024 13:48
c96fb41
to
5e808f4
Compare
johnBgood
previously approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
connectors/kafka/src/main/java/io/camunda/connector/kafka/inbound/KafkaConnectorProperties.java
Outdated
Show resolved
Hide resolved
connectors/kafka/src/main/java/io/camunda/connector/kafka/inbound/KafkaConnectorProperties.java
Outdated
Show resolved
Hide resolved
johnBgood
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Oleksiivanov
deleted the
689-migrate-kafka-inbound-connectors-to-element-template-generator
branch
April 4, 2024 10:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #
https://github.com/camunda/team-connectors/issues/689