Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asana): fix duplicated property IDs in template #2295

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

Oleksiivanov
Copy link
Contributor

Description

fix duplicated property IDs in template of Asana connector

Related issues

https://github.com/camunda/team-connectors/issues/708

@Oleksiivanov Oleksiivanov added the component:qa Task containing all details related to QA label Apr 4, 2024
@Oleksiivanov Oleksiivanov self-assigned this Apr 4, 2024
@Oleksiivanov Oleksiivanov requested a review from a team as a code owner April 4, 2024 13:01
@Oleksiivanov Oleksiivanov marked this pull request as draft April 8, 2024 12:28
@Oleksiivanov Oleksiivanov force-pushed the asana-fix-dublicated-property-ids branch from c62d484 to 744d1cb Compare April 8, 2024 13:09
@Oleksiivanov Oleksiivanov marked this pull request as ready for review April 9, 2024 08:29
johnBgood
johnBgood previously approved these changes Apr 11, 2024
Copy link
Contributor

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments 🔥

connectors/asana/element-templates/asana-connector.json Outdated Show resolved Hide resolved
"oneOf": [
"deleteTask",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be equals as we have a single value

@Oleksiivanov Oleksiivanov added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit b48c221 Apr 15, 2024
4 checks passed
@Oleksiivanov Oleksiivanov deleted the asana-fix-dublicated-property-ids branch April 15, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:qa Task containing all details related to QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants