Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): add prefix to names and suffix to IDs in hybrid mode #2339

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

Oleksiivanov
Copy link
Contributor

@Oleksiivanov Oleksiivanov commented Apr 24, 2024

Description

  • Added Hybrid prefix and -hybrid suffix for hybrid connector templates;
  • generated hybrid template for all connector that use template generator

main changes in
element-template-generator/core/src/main/java/io/camunda/connector/generator/java/ClassBasedTemplateGenerator.java

and in the

element-template-generator/core/src/main/java/io/camunda/connector/generator/java/ClassBasedTemplateGenerator.java

Screenshot 2024-04-24 at 16 51 21 Screenshot 2024-04-24 at 17 01 31

@Oleksiivanov Oleksiivanov self-assigned this Apr 24, 2024
@Oleksiivanov Oleksiivanov marked this pull request as ready for review April 24, 2024 14:05
@Oleksiivanov Oleksiivanov requested a review from a team as a code owner April 24, 2024 14:05
@Oleksiivanov Oleksiivanov force-pushed the generator-add-hybryd-prefix-and-suffix branch from 28d6af0 to 909b1df Compare April 24, 2024 14:27
chillleader
chillleader previously approved these changes Apr 25, 2024
Copy link
Member

@chillleader chillleader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for taking care of this!

@Oleksiivanov
Copy link
Contributor Author

Reference

I rebased the last main and fixed conflicts

@Oleksiivanov Oleksiivanov added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit fc6eb14 Apr 25, 2024
4 checks passed
@Oleksiivanov Oleksiivanov deleted the generator-add-hybryd-prefix-and-suffix branch April 25, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants