fix(webhook): specify permitted auth subclasses explicitly to stabilize template generation #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze the template generation
johnBgood
approved these changes
Jun 20, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.3
git worktree add -d .worktree/backport-2775-to-release/8.3 origin/release/8.3
cd .worktree/backport-2775-to-release/8.3
git switch --create backport-2775-to-release/8.3
git cherry-pick -x 5f93d4ad6f9ee93a2f750c151f2cf713fffda026 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.4
git worktree add -d .worktree/backport-2775-to-release/8.4 origin/release/8.4
cd .worktree/backport-2775-to-release/8.4
git switch --create backport-2775-to-release/8.4
git cherry-pick -x 5f93d4ad6f9ee93a2f750c151f2cf713fffda026 |
|
Successfully created backport PR for |
chillleader
added
backport release/8.6
and removed
backport release/8.3
backport release/8.4
backport release/8.5
labels
|
/backport |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR defines the list of permitted subclasses of the webhook authentication interface explicitly. Previously it has been derived implicitly because subclasses were in the same file, but in the byte code the order was not fixed, which lead to flaky template generation results and auth option reordering in the element templates.