[Backport 1.16] fix: Detect duplicated context values in distinct values() + union()
#918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5a592bc)
Add a test to verify that the function removes duplicated context values from a list. (cherry picked from commit 9c3ed24)
Move the equals comparison in a separate class to be reusable. (cherry picked from commit f5c5017)
(cherry picked from commit 88cf024)
(cherry picked from commit 9797b74)
Filter duplicate list entries by using the value comparator. The equals() for list and context values doesn't work properly because of the nested structure. (cherry picked from commit 1e30164)
Add a test to verify that the function removes duplicated context values. (cherry picked from commit 1ed648d)
Remove duplicated context entries from the concatenated list. (cherry picked from commit fa45a3d)
(cherry picked from commit 4f78808)
nicpuppa
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #908 for
1.16.All changes are the same as in the original, except there is no function
duplicate values()in version1.16.Related issues
closes #771
closes #772