Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude nodes without 'matches' (e.g. comment and text) from delegation tests #57

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Exclude nodes without 'matches' (e.g. comment and text) from delegation tests #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion helpers/-make-delegate-event-tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ function makeDelegator (domEvents) {
var el = cur === document ? document.documentElement : cur;
var matches = el.matches || el.msMatchesSelector;

if (matches.call(el, selector)) {
// Text and comment nodes may be included in mutation event targets
// but will never match selectors (and do not implement matches)
if (matches && matches.call(el, selector)) {
handlers.forEach(function(handler){
handler.call(el, ev);
});
Expand Down