Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist directory not being included in npm package #120

Open
BigAB opened this issue Jun 28, 2017 · 3 comments
Open

dist directory not being included in npm package #120

BigAB opened this issue Jun 28, 2017 · 3 comments
Labels
easy enhancement help wanted p2

Comments

@BigAB
Copy link
Contributor

BigAB commented Jun 28, 2017

When I tried to use this package with unpkg.com it did not work:

https://unpkg.com/can-fixture@1.1.0/dist/global/can-fixture.js

Because the dist directory isn't in the npm package.

image
@frank-dspeed frank-dspeed mentioned this issue Jul 22, 2017
Open
@chasenlehara
Copy link
Member

I think changing this repo’s npm scripts to match this is all that’s needed: https://github.com/canjs/can-param/blob/d3f657964b3a1f46f775d4ef3b49b4669a5a57a6/package.json#L16-L18

@BigAB BigAB mentioned this issue Aug 30, 2017
Merged
@phillipskevin
Copy link
Contributor

@BigAB so #129 didn't seem to work, right? Are you going to take another stab at this?

@BigAB
Copy link
Contributor Author

BigAB commented Sep 6, 2017

Doesn't look like it.

I don't have time at the moment, so if anyone want to take it, feel free.

Otherwise I will circle bak to it when I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement help wanted p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BigAB @phillipskevin @chasenlehara