Accept arrays as the request data #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so you can send an array as the data for a request and can-fixture won’t turn it into an object. Closes #133
chasenlehara
commented
Jan 5, 2018
| }); | ||
| xhr.open('POST', '/upload', true); | ||
| xhr.send(data); | ||
| }); |
There was a problem hiding this comment.
I don’t think this test should’ve been wrapped in the "onabort" in XMLHttpRequest._XHR.prototype check.
chasenlehara
commented
Jan 5, 2018
| // valid form types in addition to plain objects as URL search params | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/send | ||
| var formTypes = ['ArrayBuffer', 'ArrayBufferView', 'Blob', 'FormData']; | ||
|
|
There was a problem hiding this comment.
This change basically switches from explicitly checking for different types (ArrayBuffer, FormData, etc.) to checking for plain objects vs. everything else.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so you can send an array as the data for a request and can-fixture won’t turn it into an object.
Closes #133