Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated API docs from the README #69

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

imaustink
Copy link
Contributor

This pull request was created with Landscaper.
The following code mods were used to create this PR:

  1. **https://gist.github.com/imaustink/f22e65791d3b874680b6c77550bebd32**,1. **https://gist.github.com/imaustink/dc8c702f9940cc3346cc41338e890838**,1. https://gist.github.com/imaustink/72693934627c9fcc24ffbbb6b5163929

Please review this PR carefully as Landscaper does not guarantee any code mod's quality.

README.md Outdated

To publish:
[MIT](https://github.com/canjs/can-set/blob/master/LICENSE.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2. Run `npm publish`. This should generate the dist folder.
3. Create and checkout a "release" branch.
4. Run `git add -f dist`.
5. Commit the addition and tag it `git tag v0.2.0`. Push the tag `git push origin --tags`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ll need to make sure that docs like these are moved to CONTRIBUTING.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a more concise version of that we already have in the CONTRIBUTING.md file, with two differences, it uses test.html in addition to npm test, and it includes publishing instructions. Should we update all CONTRIBUTING.mds to use this as well?

README.md Outdated
environments. [can-connect](http://connect.canjs.com) uses can-set to create data modeling
utilities and middleware for the client.

[Play around in this JSBin!](https://justinbmeyer.jsbin.com/faveda/4/edit?js,console)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be keeping everything in this description.

README.md Outdated

- __returns__ <code>{[Compares](#compares-objectstringproppropavalue-bvalue-a-b-prop-algebra)}</code>:
A set compares object that can do the translation.
Read the [API docs on CanJS.com](https://canjs.com/doc/can-set.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future runs of the codemod, it might be nice to have the package name in the link, e.g. “Read the can-set API docs on CanJS.com

@imaustink imaustink force-pushed the dev-rel-12-update-generated-readmes branch 3 times, most recently from db5914b to 4e432c0 Compare August 15, 2017 23:33
@imaustink imaustink force-pushed the dev-rel-12-update-generated-readmes branch from 4e432c0 to e44cc7c Compare August 24, 2017 17:35
@imaustink imaustink force-pushed the dev-rel-12-update-generated-readmes branch from e44cc7c to 973a785 Compare August 24, 2017 17:42
@imaustink imaustink merged commit f83dc6e into master Aug 24, 2017
@chasenlehara chasenlehara deleted the dev-rel-12-update-generated-readmes branch October 31, 2017 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants