Merge pull request #83 from canjs/update-class

Element.setAttribute updates existing className
canjs · Dec 28, 2017 · 8a23ed7 · 8a23ed7
2 parents e73bb39 + 6d7f4b5
commit 8a23ed7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/simple-dom/document/element.js b/lib/simple-dom/document/element.js
@@ -56,6 +56,10 @@ Element.prototype._setAttribute = function(_name, value) {
     attr = attributes[i];
     if (attr.name === name) {
       attr.value = value;
+      const special = attrSpecial[name];
+      if(special) {
+        special(this, value);
+      }
       return;
     }
   }
@@ -67,7 +71,7 @@ Element.prototype._setAttribute = function(_name, value) {
   // a map and array
   attributes[name] = value;
 
-  let special = attrSpecial[name];
+  const special = attrSpecial[name];
   if(special) {
     special(this, value);
   }

diff --git a/lib/test/element-test.js b/lib/test/element-test.js
@@ -185,6 +185,15 @@ QUnit.test("setAttribute('class', value) updates the className", function(assert
 	assert.equal(el.className, "foo bar", "Element's className is same as the attribute class");
 });
 
+QUnit.test("setAttribute('class', value) updates an existing className", function (assert) {
+	var document = new Document();
+	var el = document.createElement("div");
+	el.setAttribute("class", "foo bar");
+	el.setAttribute("class", "baz foo");
+
+	assert.equal(el.className, "baz foo", "Element's className is updated");
+});
+
 QUnit.test("removeAttribute('class') updates the className", function (assert) {
 	var document = new Document();
 	var el = document.createElement("div");